Repository navigation
[Merged by Bors] - Remove the early exit to make sure the prepass textures are cleared - #7891
geieredgar wants to merge 1 commit into
Conversation
|
The fix seems to work. I'm somewhat confused on the concept though. Say you have a camera with DepthPrepass, but don't have any meshes with prepass_enabled. What happens both in terms of what depth textures get generated, and how the main pass uses it? |
|
With this we always begin a RenderPass, which will clear the specified color and depth attachments (the prepass specific textures). If there are no meshes, there are no draw calls so the textures will stay in their cleared state. Previously, because we exited early, no render pass was started so the textures stayed in their old state from the previous frame. |
|
That much makes sense to me. What confuses me is, what happens in the main pass then? Presumably it has an empty depth texture, which seems like it would cause problems? |
|
The depth texture is cleared with the value |
JMS55
left a comment
There was a problem hiding this comment.
After reading up on how depth testing works, this lgtm now :)
IceSentry
left a comment
There was a problem hiding this comment.
I originally had the if there to avoid unnecessary work, but I guess it's not that much code that ends up running when these are empty anyway.
|
The alternative to this would be to set a flag so that the main pass clears the depth texture itself. I don't think that's worth it, this is an unlikely situation to come up anyways. |
robtfm
left a comment
There was a problem hiding this comment.
i think this is fine. the node won't get this far if no prepass_enabled materials are used as the query above will not match (no RenderPhase would be added), so there won't be a perf impact for no-prepass use cases.
yes updating the camera's depth load op would be better so we don't need to check for all possible prepass markers in the core_3d node. something to bear in mind for if we move the rendergraph to a pure schedule. |
|
Pull request successfully merged into main. Build succeeded:
|
…evyengine#7891) # Objective - Fixes bevyengine#7888. ## Solution - Remove the early exit to make sure the prepass textures are cleared.
Objective
Solution