refactor(lint): port behavior-sensitive type rules by ematipico · Pull Request #10934 · biomejs/biome

ematipico · 2026-07-13T18:34:55Z

Summary

Continues #10933 by migrating six behavior-sensitive type-aware lint rules to the Salsa-backed inference APIs:

noBaseToString
noFloatingPromises
noMisusedPromises
useAwaitThenable
useExhaustiveSwitchCases
useNullishCoalescing

The migration removes duplicated legacy type traversal while preserving existing behavior for shadowed Promise and Array classes, dynamic union-valued switch cases, and callback overload selection.

This is an internal migration with no intended user-facing behavior change, so no changeset is required.

Test Plan

Added regression coverage for shadowed built-ins, dynamic switch cases, and overloaded callbacks.

Green CI

Docs

N/A

This PR was created with AI assistance (OpenCode).

changeset-bot · 2026-07-13T18:35:01Z

⚠️ No Changeset found

Latest commit: 84c1de7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-07-13T18:35:06Z

⚠️ Mixed activity

Activity patterns show a mix of organic and automated signals.

View full analysis →

_{This is an automated analysis by AgentScan}

ematipico · 2026-07-13T18:35:13Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed · 2026-07-16T15:10:44Z

Merging this PR will not alter performance

✅ 76 untouched benchmarks
⏩ 192 skipped benchmarks¹

_{Comparing 04-sensitive-inference-rule-ports (84c1de7) with main (68c10e6)}

192 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

dyc3 · 2026-07-16T15:21:43Z

wow, this is a lot better

Yes. The new APIs are way better to follow and to deal with!

github-actions · 2026-07-16T16:05:38Z

Parser conformance results on

js/262

Test result	`main` count	This PR count	Difference
Total	53422	53422	0
Passed	52141	52141	0
Failed	1239	1239	0
Panics	42	42	0
Coverage	97.60%	97.60%	0.00%

jsx/babel

Test result	`main` count	This PR count	Difference
Total	38	38	0
Passed	37	37	0
Failed	1	1	0
Panics	0	0	0
Coverage	97.37%	97.37%	0.00%

markdown/commonmark

Test result	`main` count	This PR count	Difference
Total	652	652	0
Passed	652	652	0
Failed	0	0	0
Panics	0	0	0
Coverage	100.00%	100.00%	0.00%

symbols/microsoft

Test result	`main` count	This PR count	Difference
Total	5467	5467	0
Passed	1915	1915	0
Failed	3552	3552	0
Panics	0	0	0
Coverage	35.03%	35.03%	0.00%

ts/babel

Test result	`main` count	This PR count	Difference
Total	677	677	0
Passed	593	593	0
Failed	84	84	0
Panics	0	0	0
Coverage	87.59%	87.59%	0.00%

ts/microsoft

Test result	`main` count	This PR count	Difference
Total	18876	18876	0
Passed	13010	13010	0
Failed	5865	5865	0
Panics	1	1	0
Coverage	68.92%	68.92%	0.00%

github-actions Bot added the agentscan:mixed-signals label Jul 13, 2026

This was referenced Jul 13, 2026

fix(workspace): make process_file call stateless #10931

Merged

fix(inference): harden Salsa type inference #10932

Merged

This was referenced Jul 13, 2026

refactor(lint): port direct type-aware rules #10933

Merged

refactor(lint): port noMisleadingReturnType #10935

Closed

fix(inference): improve imported and aliased types #10936

Merged

github-actions Bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jul 13, 2026

ematipico mentioned this pull request Jul 13, 2026

refactor(inference): remove the legacy type engine #10937

Draft

ematipico changed the base branch from 03-direct-inference-rule-ports to graphite-base/10934 July 14, 2026 13:42

ematipico force-pushed the 04-sensitive-inference-rule-ports branch from b0d01c1 to ea56a29 Compare July 14, 2026 13:43

ematipico force-pushed the graphite-base/10934 branch from 8e8bbc9 to 621e706 Compare July 14, 2026 13:43

ematipico changed the base branch from graphite-base/10934 to 03-direct-inference-rule-ports July 14, 2026 13:43

ematipico changed the base branch from 03-direct-inference-rule-ports to graphite-base/10934 July 14, 2026 13:56

ematipico force-pushed the 04-sensitive-inference-rule-ports branch from ea56a29 to 2fd36d5 Compare July 14, 2026 13:57

ematipico force-pushed the graphite-base/10934 branch from 621e706 to e2ca9c0 Compare July 14, 2026 13:57

ematipico changed the base branch from graphite-base/10934 to 03-direct-inference-rule-ports July 14, 2026 13:57

ematipico changed the base branch from 03-direct-inference-rule-ports to graphite-base/10934 July 14, 2026 14:11

ematipico force-pushed the 04-sensitive-inference-rule-ports branch from 2fd36d5 to fbc7bec Compare July 14, 2026 14:12

ematipico force-pushed the graphite-base/10934 branch from e2ca9c0 to b570a3c Compare July 14, 2026 14:12

ematipico changed the base branch from graphite-base/10934 to 03-direct-inference-rule-ports July 14, 2026 14:12

ematipico changed the base branch from 03-direct-inference-rule-ports to graphite-base/10934 July 15, 2026 08:36

ematipico force-pushed the graphite-base/10934 branch from b570a3c to 1626684 Compare July 15, 2026 08:37

ematipico force-pushed the 04-sensitive-inference-rule-ports branch from fbc7bec to 349db4f Compare July 15, 2026 08:37

ematipico changed the base branch from graphite-base/10934 to 03-direct-inference-rule-ports July 15, 2026 08:37

ematipico changed the base branch from 03-direct-inference-rule-ports to graphite-base/10934 July 15, 2026 08:44

ematipico force-pushed the 04-sensitive-inference-rule-ports branch from 349db4f to 69cab05 Compare July 15, 2026 08:45

ematipico marked this pull request as draft July 16, 2026 14:38

ematipico force-pushed the 04-sensitive-inference-rule-ports branch from b28e7e9 to 8a8933d Compare July 16, 2026 14:54

ematipico marked this pull request as ready for review July 16, 2026 14:55

ematipico requested review from a team July 16, 2026 14:57

dyc3 approved these changes Jul 16, 2026

View reviewed changes

ematipico force-pushed the 04-sensitive-inference-rule-ports branch from 8a8933d to ecff79c Compare July 16, 2026 16:00

github-actions Bot added the A-Tooling Area: internal tools label Jul 16, 2026

refactor(lint): port behavior-sensitive type rules

84c1de7

ematipico force-pushed the 04-sensitive-inference-rule-ports branch from ecff79c to 84c1de7 Compare July 16, 2026 17:03

github-actions Bot added A-Parser Area: parser L-HTML Language: HTML and super languages labels Jul 16, 2026

ematipico merged commit 89b6af4 into main Jul 16, 2026
32 checks passed

ematipico deleted the 04-sensitive-inference-rule-ports branch July 16, 2026 18:04

coderabbitai Bot mentioned this pull request Aug 5, 2026

fix(inference): query local types before global #11240

Merged

coderabbitai Bot mentioned this pull request Aug 14, 2026

feat(inference): narrow references guarded by non-typeof checks #11331

Open

Navigation Menu

Uh oh!

refactor(lint): port behavior-sensitive type rules - #10934

refactor(lint): port behavior-sensitive type rules#10934
ematipico merged 1 commit into
mainfrom
04-sensitive-inference-rule-ports

ematipico commented Jul 13, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Jul 13, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

ematipico commented Jul 13, 2026 •

edited

Loading

Uh oh!

codspeed Bot commented Jul 16, 2026 •

edited

Loading

Uh oh!

dyc3 Jul 16, 2026

Uh oh!

ematipico Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ematipico commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Docs

Uh oh!

changeset-bot Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Jul 13, 2026

⚠️ Mixed activity

Uh oh!

ematipico commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

dyc3 Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

ematipico Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 16, 2026

Parser conformance results on

js/262

jsx/babel

markdown/commonmark

symbols/microsoft

ts/babel

ts/microsoft

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ematipico commented Jul 13, 2026 •

edited

Loading

changeset-bot Bot commented Jul 13, 2026 •

edited

Loading

ematipico commented Jul 13, 2026 •

edited

Loading

codspeed Bot commented Jul 16, 2026 •

edited

Loading