Skip to content

refactor(inference): remove the legacy type engine - #10937

Draft
ematipico wants to merge 1 commit into
graphite-base/10937from
07-purge-legacy-type-engine
Draft

refactor(inference): remove the legacy type engine#10937
ematipico wants to merge 1 commit into
graphite-base/10937from
07-purge-legacy-type-engine

Conversation

@ematipico

@ematipico ematipico commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Removes the unused legacy type engine after all production consumers have moved to Salsa-backed inference. The diff contains 8,372 deletions and zero additions across legacy implementation files, tests, snapshots, the derive macro crate, and dependency entries.

Test Plan

Passed type-info, module-graph, and analyzer tests, just f, and all-target clippy. Verified every git diff --numstat additions column is zero.

Docs

N/A

This PR was created with AI assistance (OpenCode).

@changeset-bot

changeset-bot Bot commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: afeb2db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

⚠️ Mixed activity

Activity patterns show a mix of organic and automated signals.

View full analysis →

This is an automated analysis by AgentScan

This was referenced Jul 13, 2026
Merged
Merged
Merged
Merged
Closed
@ematipico Graphite App

ematipico commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ematipico ematipico mentioned this pull request Jul 13, 2026
Merged
@github-actions github-actions Bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS and super languages L-JSON Language: JSON and super languages L-HTML Language: HTML and super languages A-Type-Inference Area: type inference labels Jul 13, 2026
@ematipico
ematipico changed the base branch from 06-retire-module-resolver to graphite-base/10937 July 14, 2026 13:44
@ematipico
ematipico force-pushed the graphite-base/10937 branch from ca48a34 to 8c9a196 Compare July 14, 2026 13:45
@ematipico
ematipico force-pushed the 07-purge-legacy-type-engine branch from e35747f to 18429d6 Compare July 14, 2026 13:45
@ematipico
ematipico changed the base branch from graphite-base/10937 to 06-retire-module-resolver July 14, 2026 13:45
@ematipico
ematipico changed the base branch from 06-retire-module-resolver to graphite-base/10937 July 14, 2026 13:59
@ematipico
ematipico force-pushed the graphite-base/10937 branch from 8c9a196 to cfbc37a Compare July 14, 2026 13:59
@ematipico
ematipico force-pushed the 07-purge-legacy-type-engine branch from 18429d6 to 5366a7a Compare July 14, 2026 13:59
@ematipico
ematipico changed the base branch from graphite-base/10937 to 06-retire-module-resolver July 14, 2026 14:00
@ematipico
ematipico changed the base branch from 06-retire-module-resolver to graphite-base/10937 July 14, 2026 14:14
@ematipico
ematipico force-pushed the graphite-base/10937 branch from cfbc37a to 92e47f6 Compare July 14, 2026 14:15
@ematipico
ematipico force-pushed the 07-purge-legacy-type-engine branch from 5366a7a to 09ab105 Compare July 14, 2026 14:15
@ematipico
ematipico force-pushed the 07-purge-legacy-type-engine branch from 6ae6862 to 100e44c Compare July 17, 2026 13:16
@ematipico
ematipico changed the base branch from graphite-base/10937 to 10-return-type-relation July 17, 2026 13:16
@ematipico
ematipico changed the base branch from 10-return-type-relation to graphite-base/10937 July 17, 2026 14:07
@ematipico
ematipico force-pushed the graphite-base/10937 branch from 669cd42 to 74925f6 Compare July 17, 2026 14:10
@ematipico
ematipico force-pushed the 07-purge-legacy-type-engine branch from 100e44c to 5186570 Compare July 17, 2026 14:10
@ematipico
ematipico changed the base branch from graphite-base/10937 to 10-return-type-relation July 17, 2026 14:10
@ematipico
ematipico changed the base branch from 10-return-type-relation to graphite-base/10937 July 18, 2026 09:57
@ematipico
ematipico force-pushed the graphite-base/10937 branch from 74925f6 to dde8c28 Compare July 18, 2026 09:58
@ematipico
ematipico force-pushed the 07-purge-legacy-type-engine branch from 5186570 to 59d5bd3 Compare July 18, 2026 09:58
@ematipico
ematipico changed the base branch from graphite-base/10937 to 10-return-type-relation July 18, 2026 09:58
@ematipico
ematipico changed the base branch from 10-return-type-relation to graphite-base/10937 July 18, 2026 12:06
@ematipico
ematipico force-pushed the graphite-base/10937 branch from dde8c28 to a08634e Compare July 18, 2026 12:07
@ematipico
ematipico force-pushed the 07-purge-legacy-type-engine branch from 59d5bd3 to 42aed1d Compare July 18, 2026 12:07
@ematipico
ematipico changed the base branch from graphite-base/10937 to 10-return-type-relation July 18, 2026 12:07
@ematipico
ematipico changed the base branch from 10-return-type-relation to graphite-base/10937 July 19, 2026 15:05
This was referenced Jul 20, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ematipico
ematipico force-pushed the 07-purge-legacy-type-engine branch from 42aed1d to 863589f Compare July 20, 2026 15:02
@ematipico
ematipico force-pushed the graphite-base/10937 branch from a08634e to f0a66ee Compare July 20, 2026 15:02
@ematipico
ematipico changed the base branch from graphite-base/10937 to 17-prepare-legacy-type-removal July 20, 2026 15:02
@github-actions github-actions Bot removed the A-Linter Area: linter label Jul 20, 2026
@ematipico
ematipico changed the base branch from 17-prepare-legacy-type-removal to graphite-base/10937 July 27, 2026 09:49
@ematipico ematipico mentioned this pull request Jul 27, 2026
Merged
@ematipico
ematipico force-pushed the graphite-base/10937 branch from f0a66ee to 01b08c4 Compare July 27, 2026 09:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-CLI Area: CLI A-Project Area: project A-Type-Inference Area: type inference agentscan:mixed-signals L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ematipico