Skip to content

Infer date interval for forecast dates#54

Merged
huddlej merged 1 commit intomainfrom
fix-forecast-dates
May 22, 2025
Merged

Infer date interval for forecast dates#54
huddlej merged 1 commit intomainfrom
fix-forecast-dates

Conversation

@huddlej
Copy link
Collaborator

@huddlej huddlej commented May 16, 2025

Instead of assuming that forecasts should be produced at daily intervals, inspect the interval between the given input dates and use that interval to generate forecasts. This commit adds doctests for expected behavior and then implements that behavior.

Note this fix only works when the input dates use a fixed size interval in units of days. If the interval between dates is variable (e.g., monthly), then forecasts will be based on the interval between the last two dates in the given input.

Instead of assuming that forecasts should be produced at daily
intervals, inspect the interval between the given input dates and use
that interval to generate forecasts. This commit adds unit tests for
expected behavior and then implements that behavior.

Note this fix only works when the input dates use a fixed size interval
in units of days. If the interval between dates is variable (e.g.,
monthly), then forecasts will be based on the interval between the last
two dates in the given input.
@huddlej huddlej force-pushed the fix-forecast-dates branch from 81bf859 to 94f8275 Compare May 16, 2025 21:50
@huddlej huddlej requested a review from marlinfiggins May 16, 2025 21:50
@huddlej huddlej merged commit c0375df into main May 22, 2025
1 check passed
@huddlej huddlej deleted the fix-forecast-dates branch May 22, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Forecast dates always assume daily input data regardless of the actual input data frequency

1 participant