2D expansion to IEM module#482
Conversation
…g circular stimuli)
… functions to create 2d channels now return the centers of the channels as well.
…ction. Edited and updated docstrings.
|
@JamesWardAntony, @dhuberdeau, you should see a "Review changes" button in the "Files changed" tab: |
… expanding tests for 2D case
…lt stimulus x- & y-limits to be the same as the stimulus x- & y-limits
|
I find the Codecov "Details" link confusing. You can see what lines are not covered in the Codecov pull request interface: |
… model. added get param tests. added other statements to increase test coverage
…sertion for channel activation test.
|
@vyaivo, should we merge this PR? |
|
I'm doing a final review this afternoon and will remove the WIP/draft status when I've finished. |
…d some details in markdown text.
|
@JamesWardAntony: Since your last review I added another scoring function to the You are welcome to look at the unit tests but no need to review them. |
|
Thank you for this substantial contribution, @vyaivo & @JamesWardAntony! |
This is an initial PR so that the code co-authors can review it and make changes to the example notebook and docstrings.
Even if we only need minimal changes to
iem.py, I still need to write many unit tests for the new code. I also have not done any final formatting checks using the shell scripts.@mihaic, can you add @JamesWardAntony and @dhuberdeau as reviewers?