Avoid fetching logs for skipped jobs #11312

babakks · 2025-07-16T13:27:50Z

This PR adds a check to avoid fetching logs for skipped jobs.

A/C verification

This workflow run is a example of with a skipped job:
https://github.com/cli/cli/actions/runs/16168765316

1. An entire run log, with skipped job(s)

Given I have a run with one or more skipped jobs
When I run gh run view --log <RUN-ID>
Then The available job logs are displayed without error

Verification

Before:

gh run view --log 16168765316 | cat
# log not found: 45636838855

Now:

gh run view --log 16168765316 | cat
# (no error, empty content)

2. A single job that is skipped

Given I have a run with one or more skipped jobs
When I run gh run view --log --job <JOB-ID>
Then An empty log trail is displayed without error

Verification

Before:

gh run view --log --job 45636838855 | cat
# log not found: 45636838855

Now:

gh run view --log --job 45636838855 | cat
# (no error, empty content)

Signed-off-by: Babak K. Shandiz <babakks@github.com>

Copilot

Pull Request Overview

This PR fixes issue #11311 by adding a check to avoid fetching logs for skipped jobs, preventing "log not found" errors when running gh run view --log on workflows with skipped jobs.

Adds a skip check in the log population logic to bypass log fetching for skipped jobs
Introduces a new IsSkipped helper function to determine if a job conclusion is "skipped"
Updates test coverage to include a test case for viewing logs of skipped jobs

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
pkg/cmd/run/view/logs.go	Adds skip check before attempting to fetch logs for jobs
pkg/cmd/run/shared/shared.go	Adds IsSkipped helper function for checking skipped job conclusions
pkg/cmd/run/shared/test.go	Adds SkippedJob test fixture for testing skipped job scenarios
pkg/cmd/run/view/view_test.go	Adds test case for viewing logs of skipped jobs

pkg/cmd/run/shared/shared.go

basaveswar-kureti · 2025-07-17T14:31:07Z

Cross-posting from #11169 (comment)

Thanks @babakks for the quick fix. I verified and it is working properly. When can we expect the official build with this fix ?

% /opt/homebrew/bin/gh --repo abcd/xyz run view 16266528487 --log | grep "log not found"
log not found: 45923553930
% ./gh --repo abcd/xyz run view 16266528487 --log | grep "log not found"
% ./gh version
gh version 2.75.1-3-gf67bd9a7d (2025-07-17)
https://github.com/cli/cli/releases/latest
% git status 
On branch babakks/avoid-fetching-logs-for-skipped-jobs
Your branch is up to date with 'origin/babakks/avoid-fetching-logs-for-skipped-jobs'.

nothing to commit, working tree clean

BagToad · 2025-07-17T15:48:34Z

Thanks @babakks LGTM 🙏

I'll merge this in.

BagToad · 2025-07-17T16:25:53Z

Cross-posting from #11169 (comment)

Thanks @babakks for the quick fix. I verified and it is working properly. When can we expect the official build with this fix ?

% /opt/homebrew/bin/gh --repo abcd/xyz run view 16266528487 --log | grep "log not found"
log not found: 45923553930
% ./gh --repo abcd/xyz run view 16266528487 --log | grep "log not found"
% ./gh version
gh version 2.75.1-3-gf67bd9a7d (2025-07-17)
https://github.com/cli/cli/releases/latest
% git status 
On branch babakks/avoid-fetching-logs-for-skipped-jobs
Your branch is up to date with 'origin/babakks/avoid-fetching-logs-for-skipped-jobs'.

nothing to commit, working tree clean

@basaveswar-kureti I'm seeing if we can release today, but if not, it will be next week.

basaveswar-kureti · 2025-07-17T17:04:08Z

Cross-posting from #11169 (comment)
Thanks @babakks for the quick fix. I verified and it is working properly. When can we expect the official build with this fix ?
% /opt/homebrew/bin/gh --repo abcd/xyz run view 16266528487 --log | grep "log not found"
log not found: 45923553930
% ./gh --repo abcd/xyz run view 16266528487 --log | grep "log not found"
% ./gh version
gh version 2.75.1-3-gf67bd9a7d (2025-07-17)
https://github.com/cli/cli/releases/latest
% git status 
On branch babakks/avoid-fetching-logs-for-skipped-jobs
Your branch is up to date with 'origin/babakks/avoid-fetching-logs-for-skipped-jobs'.

nothing to commit, working tree clean
@basaveswar-kureti I'm seeing if we can release today, but if not, it will be next week.

That would be really great. Appreciate your efforts.

BagToad · 2025-07-17T18:55:57Z

Cross-posting from #11169 (comment)
Thanks @babakks for the quick fix. I verified and it is working properly. When can we expect the official build with this fix ?
% /opt/homebrew/bin/gh --repo abcd/xyz run view 16266528487 --log | grep "log not found"
log not found: 45923553930
% ./gh --repo abcd/xyz run view 16266528487 --log | grep "log not found"
% ./gh version
gh version 2.75.1-3-gf67bd9a7d (2025-07-17)
https://github.com/cli/cli/releases/latest
% git status 
On branch babakks/avoid-fetching-logs-for-skipped-jobs
Your branch is up to date with 'origin/babakks/avoid-fetching-logs-for-skipped-jobs'.

nothing to commit, working tree clean
@basaveswar-kureti I'm seeing if we can release today, but if not, it will be next week.
That would be really great. Appreciate your efforts.

@basaveswar-kureti I'll do a release today 👍 It will take some time to make it into the runner images, but that process should start on Monday.

basaveswar-kureti · 2025-07-21T15:21:33Z

Cross-posting from #11169 (comment)
Thanks @babakks for the quick fix. I verified and it is working properly. When can we expect the official build with this fix ?
% /opt/homebrew/bin/gh --repo abcd/xyz run view 16266528487 --log | grep "log not found"
log not found: 45923553930
% ./gh --repo abcd/xyz run view 16266528487 --log | grep "log not found"
% ./gh version
gh version 2.75.1-3-gf67bd9a7d (2025-07-17)
https://github.com/cli/cli/releases/latest
% git status 
On branch babakks/avoid-fetching-logs-for-skipped-jobs
Your branch is up to date with 'origin/babakks/avoid-fetching-logs-for-skipped-jobs'.

nothing to commit, working tree clean
@basaveswar-kureti I'm seeing if we can release today, but if not, it will be next week.
That would be really great. Appreciate your efforts.
@basaveswar-kureti I'll do a release today 👍 It will take some time to make it into the runner images, but that process should start on Monday.

@BagToad Thank you so much !!

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | minor | `v2.74.2` -> `v2.76.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.76.1`](https://github.com/cli/cli/releases/tag/v2.76.1): GitHub CLI 2.76.1 [Compare Source](cli/cli@v2.76.0...v2.76.1) #### `gh pr create` regression fix This release fixes a regression introduced in `v2.76.0` where organization teams were retrieved outside of intentional use cases. This caused problems for GitHub Enterprise Server users using the GitHub Actions automatic token that does not have access to organization teams. For more information, see cli/cli#11360 #### What's Changed ##### 🐛 Fixes - Fix: `gh pr create`, only fetch teams when reviewers contain a team by [@BagToad](https://github.com/BagToad) in cli/cli#11361 ##### 📚 Docs & Chores - add tenancy aware for san matcher by [@ejahnGithub](https://github.com/ejahnGithub) in cli/cli#11261 - Run Lint and Tests on `push` to `trunk` branch by [@andyfeller](https://github.com/andyfeller) in cli/cli#11325 - update ownership of pkg/cmd/release/shared/ by [@ejahnGithub](https://github.com/ejahnGithub) in cli/cli#11326 - Automate spam issue detection by [@babakks](https://github.com/babakks) in cli/cli#11316 - Improve `api` `--preview` docs by [@jsoref](https://github.com/jsoref) in cli/cli#11274 - Incorporate govulncheck into workflows by [@andyfeller](https://github.com/andyfeller) in cli/cli#11332 - chore(deps): bump advanced-security/filter-sarif from 1.0.0 to 1.0.1 by [@dependabot](https://github.com/dependabot)\[bot] in cli/cli#11298 - chore(deps): bump github.com/sigstore/sigstore-go from 1.0.0 to 1.1.0 by [@dependabot](https://github.com/dependabot)\[bot] in cli/cli#11307 **Full Changelog**: cli/cli@v2.76.0...v2.76.1 ### [`v2.76.0`](https://github.com/cli/cli/releases/tag/v2.76.0): GitHub CLI 2.76.0 [Compare Source](cli/cli@v2.75.1...v2.76.0) ####

Copilot Coding Agent Support GitHub Copilot Pro+ and Copilot Enterprise subscribers can now assign issues to GitHub Copilot during issue creation using: - Command-line flag: `gh issue create --assignee @copilot` - Launching web browser: `gh issue create --assignee @copilot --web` - Or interactively selecting `Copilot (AI)` as assignee in `gh issue create` metadata For more details, refer to [the full changelog post for Copilot coding agent](https://github.blog/changelog/2025-05-19-github-copilot-coding-agent-in-public-preview/). #### What's Changed ##### ✨ Features - Assign Copilot during `gh issue create` by [@andyfeller](https://github.com/andyfeller) in cli/cli#11279 - Display immutable field in `release view` command by [@bdehamer](https://github.com/bdehamer) in cli/cli#11251 ##### 🐛 Fixes - FIX: Do not fetch logs for skipped jobs by [@babakks](https://github.com/babakks) in cli/cli#11312 - Transform `extension` and `filename` qualifiers into `path` qualifier for web code search by [@samcoe](https://github.com/samcoe) in cli/cli#11211 ##### 📚 Docs & Chores - FIX: Workflow does not contain permissions by [@BagToad](https://github.com/BagToad) in cli/cli#11322 - Add automated feature request response workflow by [@BagToad](https://github.com/BagToad) in cli/cli#11299 **Full Changelog**: cli/cli@v2.75.1...v2.76.0 ### [`v2.75.1`](https://github.com/cli/cli/releases/tag/v2.75.1): GitHub CLI 2.75.1 [Compare Source](cli/cli@v2.75.0...v2.75.1) #### What's Changed ##### 🐛 Fixes - Ensure hostnames are visible in CLI website by [@andyfeller](https://github.com/andyfeller) in cli/cli#11295 - Revert "Fix: `gh pr create` prioritize `--title` and `--body` over `--fill` when `--web` is present" by [@andyfeller](https://github.com/andyfeller) in cli/cli#11300 ##### 📚 Docs & Chores - Ensure go directive is always .0 version in bump by [@williammartin](https://github.com/williammartin) in cli/cli#11259 - Minor (1-word) documentation typo in generated `~/.config/gh/config.yml` by [@kurahaupo](https://github.com/kurahaupo) in cli/cli#11246 - Automate closing of stale issues by [@babakks](https://github.com/babakks) in cli/cli#11268 - Filter the `third-party/` folder out of CodeQL results by [@BagToad](https://github.com/BagToad) in cli/cli#11278 - Exclude `third-party` source from golangci-lint by [@andyfeller](https://github.com/andyfeller) in cli/cli#11293 #####

Dependencies - Bump Go to 1.24.5 by [@github-actions](https://github.com/github-actions)\[bot] in cli/cli#11255 - chore(deps): bump github.com/sigstore/protobuf-specs from 0.4.3 to 0.5.0 by [@dependabot](https://github.com/dependabot)\[bot] in cli/cli#11263 - chore(deps): bump golang.org/x/term from 0.32.0 to 0.33.0 by [@dependabot](https://github.com/dependabot)\[bot] in cli/cli#11266 - chore(deps): bump golang.org/x/sync from 0.15.0 to 0.16.0 by [@dependabot](https://github.com/dependabot)\[bot] in cli/cli#11264 - chore(deps): bump golang.org/x/text from 0.26.0 to 0.27.0 by [@dependabot](https://github.com/dependabot)\[bot] in cli/cli#11265 - chore(deps): bump golang.org/x/crypto from 0.39.0 to 0.40.0 by [@dependabot](https://github.com/dependabot)\[bot] in cli/cli#11275 #### New Contributors - [@kurahaupo](https://github.com/kurahaupo) made their first contribution in cli/cli#11246 - [@github-actions](https://github.com/github-actions)\[bot] made their first contribution in cli/cli#11255 **Full Changelog**: cli/cli@v2.75.0...v2.75.1 ### [`v2.75.0`](https://github.com/cli/cli/releases/tag/v2.75.0): GitHub CLI 2.75.0 [Compare Source](cli/cli@v2.74.2...v2.75.0) #### What's Changed ##### ✨ Features - init release verify subcommands by [@ejahnGithub](https://github.com/ejahnGithub) in cli/cli#11018 - Embed Windows resources (VERSIONINFO) during build by [@babakks](https://github.com/babakks) in cli/cli#11048 - Support `--no-repos-selected` on `gh secret set` by [@williammartin](https://github.com/williammartin) in cli/cli#11217 ##### 🐛 Fixes - Fix: `gh pr create` prioritize `--title` and `--body` over `--fill` when `--web` is present by [@dankrzeminski32](https://github.com/dankrzeminski32) in cli/cli#10547 - fix: get token for active user instead of blank if possible by [@anuraaga](https://github.com/anuraaga) in cli/cli#11038 - Use Actions API to retrieve job run logs as a fallback mechanism by [@babakks](https://github.com/babakks) in cli/cli#11172 - Fix query object state mutation during pagination by [@babakks](https://github.com/babakks) in cli/cli#11244 - Handle `HTTP 404` when deleting remote branch in `pr merge` by [@babakks](https://github.com/babakks) in cli/cli#11234 ##### 📚 Docs & Chores - chore: fix function name by [@jinjingroad](https://github.com/jinjingroad) in cli/cli#11149 - chore: update Go version to 1.24 in devcontainer configuration and docs by [@tMinamiii](https://github.com/tMinamiii) in cli/cli#11158 - Ensure lint workflow checks whether 3rd party license and code is up to date by [@andyfeller](https://github.com/andyfeller) in cli/cli#11047 - docs: install\_linux.md: add Solus linux install instructions by [@chax](https://github.com/chax) in cli/cli#10823 - Fix missing newline in install\_linux.md by [@BagToad](https://github.com/BagToad) in cli/cli#11160 - Ensure automation uses pinned go-licenses version by [@andyfeller](https://github.com/andyfeller) in cli/cli#11161 - Add `workflow_dispatch` support to MR Help Wanted check by [@BagToad](https://github.com/BagToad) in cli/cli#11179 - Remove unused `GH_TOKEN` env variable from workflow by [@BagToad](https://github.com/BagToad) in cli/cli#11190 - Add workflow to automate go version bumping by [@williammartin](https://github.com/williammartin) in cli/cli#11189 - Fix inconsistent use of tabs and spaces by [@Stefan-Heimersheim](https://github.com/Stefan-Heimersheim) in cli/cli#11194 - Decouple arg parsing from MR finder by [@babakks](https://github.com/babakks) in cli/cli#11192 - docs: consistently use `apt` in installation instructions by [@tklauser](https://github.com/tklauser) in cli/cli#11216 - Ensure bump go script has git user configured by [@williammartin](https://github.com/williammartin) in cli/cli#11229 - Inject token into bump-go workflow by [@williammartin](https://github.com/williammartin) in cli/cli#11233 - Reinstating Primer Style CLI content within `cli/cli` repository by [@andyfeller](https://github.com/andyfeller) in cli/cli#11060 - Add setup-go to bump-go workflow by [@williammartin](https://github.com/williammartin) in cli/cli#11237 - Ensure GoReleaser does not break on Mac OS and Linux when skipping Windows `.rsyso` generation script by [@andyfeller](https://github.com/andyfeller) in cli/cli#11257 #####

Dependencies - Bump all dependencies except dev-tunnels by [@williammartin](https://github.com/williammartin) in cli/cli#11203 - Update microsoft dev-tunnels to v0.1.13 by [@williammartin](https://github.com/williammartin) in cli/cli#11205 - Consume dependabot minor versions for go modules by [@williammartin](https://github.com/williammartin) in cli/cli#11213 #### New Contributors - [@jinjingroad](https://github.com/jinjingroad) made their first contribution in cli/cli#11149 - [@tMinamiii](https://github.com/tMinamiii) made their first contribution in cli/cli#11158 - [@chax](https://github.com/chax) made their first contribution in cli/cli#10823 - [@dankrzeminski32](https://github.com/dankrzeminski32) made their first contribution in cli/cli#10547 - [@anuraaga](https://github.com/anuraaga) made their first contribution in cli/cli#11038 - [@Stefan-Heimersheim](https://github.com/Stefan-Heimersheim) made their first contribution in cli/cli#11194 **Full Changelog**: cli/cli@v2.74.2...v2.75.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

babakks added 3 commits July 16, 2025 14:19

fix(run): add IsSkipped function

2ce3279

Signed-off-by: Babak K. Shandiz <babakks@github.com>

fix(run view): avoid looking for job log if its been skipped

64d5d6c

Signed-off-by: Babak K. Shandiz <babakks@github.com>

test(run view): assert a skipped job does not cause error

f67bd9a

Signed-off-by: Babak K. Shandiz <babakks@github.com>

Copilot AI review requested due to automatic review settings July 16, 2025 13:27

babakks requested a review from a team as a code owner July 16, 2025 13:27

babakks linked an issue Jul 16, 2025 that may be closed by this pull request

v2.75 fails downloading logs from workflows with skipped jobs #11311

Closed

babakks requested a review from BagToad July 16, 2025 13:27

babakks temporarily deployed to cli-automation July 16, 2025 13:27 — with GitHub Actions Inactive

cliAutomation assigned babakks Jul 16, 2025

Copilot AI reviewed Jul 16, 2025

View reviewed changes

pkg/cmd/run/shared/shared.go Show resolved Hide resolved

babakks changed the title ~~Babakks/avoid fetching logs for skipped jobs~~ Avoid fetching logs for skipped jobs Jul 16, 2025

babakks mentioned this pull request Jul 16, 2025

Use Actions API to retrieve job run logs as a fallback mechanism #11169

Closed

BagToad approved these changes Jul 17, 2025

View reviewed changes

BagToad merged commit 73cb3ec into trunk Jul 17, 2025
19 checks passed

BagToad deleted the babakks/avoid-fetching-logs-for-skipped-jobs branch July 17, 2025 15:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Avoid fetching logs for skipped jobs #11312

Avoid fetching logs for skipped jobs #11312

Uh oh!

babakks commented Jul 16, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

basaveswar-kureti commented Jul 17, 2025

Uh oh!

BagToad commented Jul 17, 2025

Uh oh!

Uh oh!

BagToad commented Jul 17, 2025

Uh oh!

basaveswar-kureti commented Jul 17, 2025

Uh oh!

BagToad commented Jul 17, 2025

Uh oh!

basaveswar-kureti commented Jul 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Avoid fetching logs for skipped jobs #11312

Avoid fetching logs for skipped jobs #11312

Uh oh!

Conversation

babakks commented Jul 16, 2025

A/C verification

1. An entire run log, with skipped job(s)

Verification

2. A single job that is skipped

Verification

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

basaveswar-kureti commented Jul 17, 2025

Uh oh!

BagToad commented Jul 17, 2025

Uh oh!

Uh oh!

BagToad commented Jul 17, 2025

Uh oh!

basaveswar-kureti commented Jul 17, 2025

Uh oh!

BagToad commented Jul 17, 2025

Uh oh!

basaveswar-kureti commented Jul 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants