lockfiles - #5412
Merged
Merged
lockfiles#5412
Conversation
Closed
memsharded
marked this pull request as ready for review
June 28, 2019 04:09
lasote
suggested changes
Jun 28, 2019
| parser.add_argument('-k', '-ks', '--keep-source', default=False, action='store_true', | ||
| help=_KEEP_SOURCE_HELP) | ||
| parser.add_argument("-l", "--lockfile", action=OnceArgument, nargs='?', const=".", | ||
| help="Path to lockfile. Lockfile will be updated with " |
| merge_cmd.add_argument('new_lockfile', help='path to modified lockfile') | ||
|
|
||
| build_order_cmd = subparsers.add_parser('build-order', help='Returns build-order') | ||
| build_order_cmd.add_argument('lockfile', help='lockfile folder') |
Contributor
There was a problem hiding this comment.
Path to a folder containing a conan.lock file
lasote
suggested changes
Jun 28, 2019
Contributor
|
Of course, we need goods docs also. I think the better would be to document the typical usage of the locks with examples. We can describe (later, probably when better tested) in another section the CI flows, recommendations, alternatives... etc. |
Contributor
|
What about the suggestions for the command help? Don't you want to change them? |
Member
Author
|
Actually, the --lockfile argument support also using custom files, so not only the folder, but also different filenames. It was already there, but not tested, I have added some test to have it covered. |
Contributor
|
Oh! Then |
3 tasks
…an-io#5441) * Fix verify_ssl field in SCM discarded when used with False value * Added comment * leave only None check * Also discard empty strings to avoid breaking tests
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Implementation of lockfiles. Lockfiles store in a file all the configuration, exact versions (including revisions), necessary to achieve reproducible builds, even when using version-ranges or package revisions.
Docs: conan-io/docs#1350
--lockfile
--lockfilethat applies to multiple commands (create, install, info, test) and acts both as input and output--lockfileis the current dir, and the default filename isconan.lock--lockfileconan install .will generate aconan.lockfile by default, without needing to specify an output, but won't be used unless--lockfileis specified.New command
conan graphconan graph lockgenerates a new conan.lock lockfile. This is necessary if we don't want to actually install binaries yet (CI), and theconan infowill fail if we try to specify a profile or settingsconan graph build-ordergets a lockfile and outputs a list of lists in order to be build: Each item has the node ID, not used yet, and the package reference of the node to buildconan graph updateis able to update a lockfile with another lockfile, that has been modified (like building some of its packages again)conan graph clean-modifiedremoves the "modified" flag from all packages in a lockfile