chore(text-field): Remove password attribute - #42
Merged
Conversation
This attribute has been deprecated for some time. Usages have been
emitting a warning.
BREAKING CHANGE: `text_field password: true` now creates a `text` input
This change removes the warning and the intermediate behavior of mapping
`text_field password: true` to `text_field behavior: :password`. Migrate
password fields using the deprecated `password` attribute to the
following:
text_field behavior: :password
dsgraham
approved these changes
Dec 6, 2023
jadefish
pushed a commit
that referenced
this pull request
Dec 8, 2023
feat: Modify toggle_disabled event to take a CSS selector instead of id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attribute has been deprecated for some time. Usages have been emitting a warning.
BREAKING CHANGE:
text_field password: truenow creates atextinputThis change removes the warning and the intermediate behavior of mapping
text_field password: truetotext_field behavior: :password. Migrate password fields using the deprecatedpasswordattribute to the following: