Skip to content

chore(text-field): Remove password attribute #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jadefish merged 1 commit into from
Dec 8, 2023
Merged

chore(text-field): Remove password attribute #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions lib/coprl/presenters/dsl/components/text_field.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def initialize(**attribs_, &block)
@auto_complete = validate_auto_complete(attribs.delete(:auto_complete) { :off })
@default_value = attribs.delete(:default_value) if attribs.key?(:default_value)
@tab_index = validate_tab_index(attribs.delete(:tab_index)) if attribs.key?(:tab_index)
@behavior = determine_behavior(attribs.delete(:password), attribs.delete(:behavior))
@behavior = attribs.delete(:behavior)
label(attribs.delete(:label))if attribs.key?(:label)
value(attribs.delete(:value))if attribs.key?(:value)
expand!
Expand Down Expand Up @@ -95,24 +95,6 @@ def validate_tab_index(tab_index)
raise Errors::ParameterValidation, "Tab Index needs to be an int" unless tab_index.is_a?(Integer)
tab_index
end

def determine_behavior(password, behavior)
unless password.nil?
logger.warn(
'The `password` attribute of text_field is deprecated. ' \
'Use `text_field behavior: :password` instead.'
)
end

case password
when nil
behavior
when true
:password
when false
:text
end
end
end
end
end
Expand Down