[Testing] Read the test-config's test_env values in require_env - #21099
Merged
Mytherin merged 1 commit intoMar 3, 2026
Merged
Conversation
… be influenced by the config and skipped based on configs being used/not used
Collaborator
|
Thanks! |
krlmlr
added a commit
to krlmlr/duckdb-r-old
that referenced
this pull request
Mar 3, 2026
Date: 2026-03-03 09:13:07 +0100 Add TEnumIterator::operator== (duckdb/duckdb#21135) [Testing] Read the test-config's `test_env` values in `require_env` (duckdb/duckdb#21099) Fix unclassified errors for PEG parser (Part 2) (duckdb/duckdb#21097)
krlmlr
added a commit
to krlmlr/duckdb-r-old
that referenced
this pull request
Mar 3, 2026
Date: 2026-03-03 09:13:07 +0100 Add TEnumIterator::operator== (duckdb/duckdb#21135) [Testing] Read the test-config's `test_env` values in `require_env` (duckdb/duckdb#21099) Fix unclassified errors for PEG parser (Part 2) (duckdb/duckdb#21097)
krlmlr
pushed a commit
to krlmlr/duckdb
that referenced
this pull request
Jun 21, 2026
…t when `test_env` is used (duckdb#21305) This PR is a follow-up to duckdb#21099 Problem is fixed by making sure `test_env` gets loaded only once, and we make sure environment variables provided by `test_env` don't get falsely flagged as "double defined"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so that test behavior can be influenced by the config and skipped based on configs being used/not used.