[Dev] Fix "environment variable already defined" error in sqllogictest when test_env is used - #21305
Merged
Mytherin merged 3 commits intoJun 11, 2026
Merged
Conversation
Member
Author
|
I can see this: // setup this test runner with Config-based env, then override with ephemerals (only WORKING_DIR at this point)
for (auto &kv : test_config.GetTestEnvMap()) {
runner.environment_variables[kv.first] = kv.second;
}And the Aha, figured it out So for the next run, |
|
This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
This pull request was closed because it has been stale for 30 days with no activity. |
Collaborator
|
Thanks! |
krlmlr
pushed a commit
to krlmlr/duckdb
that referenced
this pull request
Jun 21, 2026
Conflict-free merge of the clean commits between resolutions: - Fix crash when storage path is not set (duckdb#23174) - Zero the inlined buffer in string_t's length-only constructor (duckdb#23201) - [Dev] Fix "environment variable already defined" error in sqllogictest when `test_env` is used (duckdb#21305) - parquet: initialize `ParquetReader::rows_read` (duckdb#23205)
krlmlr
pushed a commit
to krlmlr/duckdb
that referenced
this pull request
Jun 21, 2026
…t when `test_env` is used (duckdb#21305) This PR is a follow-up to duckdb#21099 Problem is fixed by making sure `test_env` gets loaded only once, and we make sure environment variables provided by `test_env` don't get falsely flagged as "double defined"
krlmlr
pushed a commit
to krlmlr/duckdb
that referenced
this pull request
Jun 21, 2026
Conflict-free merge of the clean commits between resolutions: - Fix crash when storage path is not set (duckdb#23174) - Zero the inlined buffer in string_t's length-only constructor (duckdb#23201) - [Dev] Fix "environment variable already defined" error in sqllogictest when `test_env` is used (duckdb#21305) - parquet: initialize `ParquetReader::rows_read` (duckdb#23205)
krlmlr
pushed a commit
to krlmlr/duckdb
that referenced
this pull request
Jun 21, 2026
Brings these v1.5-variegata commits; they do not overlap with the main/v2.0 line, so they merge with no conflicts: - Fix crash when storage path is not set (duckdb#23174) - Zero the inlined buffer in string_t's length-only constructor (duckdb#23201) - [Dev] Fix "environment variable already defined" error in sqllogictest when `test_env` is used (duckdb#21305) - parquet: initialize `ParquetReader::rows_read` (duckdb#23205)
krlmlr
pushed a commit
to krlmlr/duckdb
that referenced
this pull request
Jun 21, 2026
Brings these v1.5-variegata commits; they do not overlap with the main/v2.0 line, so they merge with no conflicts: - Fix crash when storage path is not set (duckdb#23174) - Zero the inlined buffer in string_t's length-only constructor (duckdb#23201) - [Dev] Fix "environment variable already defined" error in sqllogictest when `test_env` is used (duckdb#21305) - parquet: initialize `ParquetReader::rows_read` (duckdb#23205)
kaka11chen
pushed a commit
to kaka11chen/astrovela_vane
that referenced
this pull request
Aug 14, 2026
…t when `test_env` is used (duckdb/duckdb#21305) This PR is a follow-up to #21099 Problem is fixed by making sure `test_env` gets loaded only once, and we make sure environment variables provided by `test_env` don't get falsely flagged as "double defined" Upstream-Commit: duckdb/duckdb@dc6a0be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #21099
Problem is fixed by making sure
test_envgets loaded only once, and we make sure environment variables provided bytest_envdon't get falsely flagged as "double defined"