Conversation
|
@llucenic Thank you!
Such case is need to cover by integration test |
|
Denis, I do not understand fully your point regarding integration test. Is it possible you kind of fix the tests yourself? |
|
It is common practice to immediately implement a test with a PR, yep? Is there some problem with this? |
|
I have corrected the code, so that it passes at least some of the check jobs. However, the rest of the failures are beyond the scope of my PR. At the moment, I cannot do much more. Maybe later, and I am not sure though the code I added follows your design of the library. Therefore I have asked you to add the tests yourself while integrating the changes into your code base. |
|
Maybe implementation of ranges as a separate PR would be the best solution. Otherwise this PR is too big. |
Yes, looks like this issues itroduced by new compilers and will be solved not in this repository. But I am worry about lack of integration tests for ranges. This is fundamentally new structures, I would like to cover with tests at least one of each base type. If it is too difficult feel free to copy and paste here your actual code what works with it and I'll try to implement test by myself |
|
If integration tests for ranges are what makes you integrate this PR in your library, then I think I can provide them. Assuming that we avoid splitting this PR, which does not make much sense to me (as implementation of ranges is only code in conv/ranges.d). |
Signed-off-by: Ľudovít Lučenič <ludovit.lucenic@digital-orchestra.sk>
Signed-off-by: Ľudovít Lučenič <ludovit.lucenic@digital-orchestra.sk>
Signed-off-by: Ľudovít Lučenič <ludovit.lucenic@digital-orchestra.sk>
Signed-off-by: Ľudovít Lučenič <ludovit.lucenic@digital-orchestra.sk>
Signed-off-by: Ľudovít Lučenič <ludovit.lucenic@digital-orchestra.sk>
…ange), napr. pri načítaní zhora otvoreného časového intervalu, ktorého horná a dolná hranica sú totožné, a nie sú teda Null ani Inf Signed-off-by: Ľudovít Lučenič <ludovit.lucenic@digital-orchestra.sk>
…a multirozsahov požadované pre prijatie žiadosti o včlenenie kódu do hlavného vývoja knižnice dpq2 Signed-off-by: Ľudovít Lučenič <ludovit.lucenic@digital-orchestra.sk>
|
Hello, I finally got around to fulfill my promise regarding tests for ranges. Actually, I have prepared tests for ranges, range arrays, multiranges and multirange arrays altogether. I hope now (all) my contribution might be merged into main development of your library. Thank you for letting me know. p.s. the solution at this stage aims solely on reading the data from the database consistently (so convenient writing using some D structs with user-friendly interface is missing); therefore the tests use the simplified (and somehow low-level) byte array constructors; there is this possibility of adding appropriate contructors left open for later updates |
|
Regarding the merge conflict, there is only this RecordArray literal to be added from master branch into the pulled version. |
I made some minor changes to this PR here: llucenic#1 The only problem is that my PR also contains a merged ~master, so it is difficult to perceive. My proposal:
|
…nej vetvy verzie pre platformu Arinas Signed-off-by: Ľudovít Lučenič <ludovit.lucenic@digital-orchestra.sk>
…ged with v1.2.0) Signed-off-by: Ľudovít Lučenič <ludovit.lucenic@digital-orchestra.sk>
|
Hi, I followed the steps from your proposal and it seems to be ready now for merge on your side. |
Attempt 2: Tabs converted to spaces, comments for OidType enum added
…adosti o včlenenie kódu do hlavného vývoja knižnice dpq2 Signed-off-by: Ľudovít Lučenič <ludovit.lucenic@digital-orchestra.sk>
Signed-off-by: Ľudovít Lučenič <ludovit.lucenic@digital-orchestra.sk>
Hello, I have added support for all native PostgreSQL user data types (ranges, multiranges, network, bitstrings, geometry, xml and text search vector/query), for now except for multi-dimensional arrays and user-defined types. In order to add support for OidType.PointArray I had to explicitely distinguish between Point[] and Polygon by defining a solid struct Point in dpq2.conv.geometry. Please review and incorporate the changes in the code base on your sole discretion.