Skip to content

Almost all native PostgreSQL user data types implementation - #206

Open
denizzzka wants to merge 9 commits into
masterfrom
remove_net_capabilities
Open

denizzzka wants to merge 9 commits into
masterfrom
remove_net_capabilities

Conversation

@denizzzka

Copy link
Copy Markdown
Owner

Almost all native PostgreSQL user data types (ranges, multiranges, bitstrings, geometry, xml and text search vector/query), implemented by @llucenic

Cutted from #193 to simplify PR

Ľudovít Lučenič and others added 6 commits January 29, 2025 11:35
…ged with v1.2.0)

Signed-off-by: Ľudovít Lučenič <ludovit.lucenic@digital-orchestra.sk>
Attempt 2: Tabs converted to spaces, comments for OidType enum added
It requires additional work - will be implemented as separate commit
@codecov-commenter

codecov-commenter commented Jan 30, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 55.51601% with 125 lines in your changes missing coverage. Please review.

Project coverage is 82.41%. Comparing base (f027852) to head (bb73438).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/dpq2/conv/tsearch.d 0.00% 72 Missing ⚠️
src/dpq2/conv/ranges.d 70.90% 16 Missing ⚠️
src/dpq2/oids.d 72.72% 15 Missing ⚠️
src/dpq2/conv/bit.d 0.00% 10 Missing ⚠️
src/dpq2/conv/geometric.d 52.94% 8 Missing ⚠️
src/dpq2/conv/to_bson.d 0.00% 3 Missing ⚠️
src/dpq2/value.d 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   87.08%   82.41%   -4.68%     
==========================================
  Files          21       24       +3     
  Lines        1649     1916     +267     
==========================================
+ Hits         1436     1579     +143     
- Misses        213      337     +124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denizzzka

Copy link
Copy Markdown
Owner Author

@llucenic your help is needed here: it is need to cover by coverage newly added file or just remove uncovered code

Everything else here is good

@llucenic

Copy link
Copy Markdown
Contributor

What does this exactly mean? I have provided tests that effectively cover the code added by me, e.g. for ranges and it says 0% here...

@denizzzka

Copy link
Copy Markdown
Owner Author

tsearch.d is 0% covered says dmd with -cov key. I intentionally tried to add error to it and nothing happened

How to run:

$ dub run :integration_tests --compiler=dmd --config=dynamic-unmanaged --build=cov -- --conninfo="dbname=postgres"

@llucenic

llucenic commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

I have added tsearch (TsQuery and TsVector) test cases, so that the coverage should now be in place. @denizzzka, please let me know, if it is sufficient now.

@denizzzka

denizzzka commented Feb 4, 2025

Copy link
Copy Markdown
Owner Author

I don't see any changes here: please add them to this branch by PR or take this branch for yourself and merge to your PR or create new one.

#193 is not suitable because it uses tabs instead of spaces and provides untested inet type support wich will be replaced by code proposed in #208

@llucenic

llucenic commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

Hello, I see with 4565834 you have already moved the addition into your temporary branch. Is there anything necessary from me, at the moment?

@denizzzka

denizzzka commented Feb 7, 2025

Copy link
Copy Markdown
Owner Author

Hello, I see with 4565834 you have already moved the addition into your temporary branch.

No, TsQuery and TsVector tests is missing here

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants