Conversation
…ged with v1.2.0) Signed-off-by: Ľudovít Lučenič <ludovit.lucenic@digital-orchestra.sk>
Attempt 2: Tabs converted to spaces, comments for OidType enum added
It requires additional work - will be implemented as separate commit
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #206 +/- ##
==========================================
- Coverage 87.08% 82.41% -4.68%
==========================================
Files 21 24 +3
Lines 1649 1916 +267
==========================================
+ Hits 1436 1579 +143
- Misses 213 337 +124 ☔ View full report in Codecov by Sentry. |
|
@llucenic your help is needed here: it is need to cover by coverage newly added file or just remove uncovered code Everything else here is good |
|
What does this exactly mean? I have provided tests that effectively cover the code added by me, e.g. for ranges and it says 0% here... |
|
How to run: $ dub run :integration_tests --compiler=dmd --config=dynamic-unmanaged --build=cov -- --conninfo="dbname=postgres" |
|
I have added tsearch (TsQuery and TsVector) test cases, so that the coverage should now be in place. @denizzzka, please let me know, if it is sufficient now. |
|
Hello, I see with 4565834 you have already moved the addition into your temporary branch. Is there anything necessary from me, at the moment? |
No, |
Almost all native PostgreSQL user data types (ranges, multiranges, bitstrings, geometry, xml and text search vector/query), implemented by @llucenic
Cutted from #193 to simplify PR