Skip to content

Remove deprecated xpack.security.enabled config option - #111681

Merged
legrego merged 7 commits into
elastic:masterfrom
watson:config-security-enabled
Oct 25, 2021
Merged

Remove deprecated xpack.security.enabled config option#111681
legrego merged 7 commits into
elastic:masterfrom
watson:config-security-enabled

Conversation

@watson

@watson watson commented Sep 9, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Depends on #111706

This config option is already deprecated in 7.x.

To enable or disable the security plugin, set this option in Elasticsearch instead.

Closes #54023

Release note

Removes the deprecated "xpack.security.enabled" config option. This should instead be controlled via the similarly named config option in elasticsearch.yml.

@watson watson added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Sep 9, 2021
@watson watson self-assigned this Sep 9, 2021
@watson watson removed the release_note:skip Skip the PR/issue when compiling release notes label Sep 9, 2021
@watson watson mentioned this pull request Sep 9, 2021
Closed
@watson watson changed the title Remove xpack.security.enabled config option from Kibana Remove deprecated xpack.security.enabled config option Sep 9, 2021
@watson
watson force-pushed the config-security-enabled branch from 8d9d046 to c9ec68a Compare September 9, 2021 10:55
@jportner

jportner commented Sep 9, 2021

Copy link
Copy Markdown
Contributor

@elastic/kibana-core Thomas started this PR to address #54023

However, there is overlap with your larger issue #89584. To quote that issue:

Toward the end of the 7.16 dev cycle, we will open a PR removing enabled from any plugins that don't have a yes indicated below. To prepare for this update, we'd ask that folks review the affected plugins by 31 August 2021.

The Security plugin currently has an explicit config option for enabled. Should we be removing it in this PR, or would you prefer to tackle it as part of your larger issue?

@lukeelmers

lukeelmers commented Sep 9, 2021

Copy link
Copy Markdown
Contributor

The Security plugin currently has an explicit config option for enabled. Should we be removing it in this PR, or would you prefer to tackle it as part of your larger issue?

Feel free to remove it in this PR -- currently I am readying a PR to add deprecations to all affected plugins which don't have one yet, but our PR to do the actual removal of the old configs won't come until a follow-up PR. So if this PR merges in the interim, that should be fine.

@watson
watson force-pushed the config-security-enabled branch 2 times, most recently from ee269cc to ccee01f Compare October 20, 2021 20:36
@elastic elastic deleted a comment from kibanamachine Oct 21, 2021
@watson
watson force-pushed the config-security-enabled branch 2 times, most recently from 8614e8b to a287ed9 Compare October 21, 2021 17:31
watson added 6 commits October 21, 2021 20:13
@watson
Remove xpack.security.enabled config option from Kibana
e0c2e8b 
To enable or disable the security plugin, set this option in
Elasticsearch instead.
@watson
Update snapshots to not include the enabled config option
ac485f7
@watson
Don't accidentally try to set xpack.security.enabled in Kibana config
cb739c7
@watson
Inherit xpack.security.enabled from Elasticsearch in tests
4c4d474
@watson
Fix ui_capabilities test error
8c3f9e2
@watson
Bump expected number of integrations in fleet test
e8ace45 
The 21 new integrations are all enterprise_search integrations which
wasn't included before because the security plugin was disabled (a
dependency of enterprise_search).
@watson
watson force-pushed the config-security-enabled branch from a287ed9 to e8ace45 Compare October 21, 2021 18:13
@watson
watson marked this pull request as ready for review October 21, 2021 18:14
@watson
watson requested review from a team as code owners October 21, 2021 18:14
kpollich
kpollich approved these changes Oct 25, 2021
View reviewed changes

@kpollich kpollich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is the only Fleet-related change in question. Approving for Fleet codeowner review 🚀

jportner
jportner approved these changes Oct 25, 2021
View reviewed changes

@jportner jportner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

tsullivan
tsullivan approved these changes Oct 25, 2021
View reviewed changes

@tsullivan tsullivan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporting changes LGTM

@joshdover joshdover mentioned this pull request Oct 25, 2021
Closed
@legrego
legrego merged commit f152787 into elastic:master Oct 25, 2021
@watson
watson deleted the config-security-enabled branch October 26, 2021 08:09
@KOTungseth KOTungseth mentioned this pull request Nov 1, 2021
Merged
jportner added a commit that referenced this pull request Apr 11, 2022
@jportner
[7.17] Test config settings that are exposed to the browser (#129438) (…
6ba02ec 
…#129857)

* Test config settings that are exposed to the browser (#129438)

(cherry picked from commit 27ff7d3)

# Conflicts:
#	.github/CODEOWNERS
#	packages/kbn-config-schema/src/index.ts

* Enable security plugin in OSS tests

This is a partial backport of #111681, so the Kibana security
plugin is enabled but Elasticsearch security is still disabled.

* Fix exposed config key tests

The exposed config keys are slightly different in the 7.17 branch.

* Fix UI Capabilities tests

The enterpriseSearch plugin does not have a required dependency on
the security plugin in the 7.17 branch, so our bacported
assertions for these tests needed to change accordingly.
robb3rt pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
Robbert Hink
adjust for removed kibana security settings
2fe7953 
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards
@robb3rt robb3rt mentioned this pull request Nov 3, 2022
Merged
dedemorton pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
Robbert Hink
adjust for removed kibana security settings (#2315)
fe73e13 
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards
mergify Bot pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
Robbert Hink @mergify
adjust for removed kibana security settings (#2315)
70cffd7 
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)
mergify Bot pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
Robbert Hink @mergify
adjust for removed kibana security settings (#2315)
d4034db 
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)
mergify Bot pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
Robbert Hink @mergify
adjust for removed kibana security settings (#2315)
aecf565 
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)
mergify Bot pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
Robbert Hink @mergify
adjust for removed kibana security settings (#2315)
14b7856 
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)
mergify Bot pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
Robbert Hink @mergify
adjust for removed kibana security settings (#2315)
381a4c3 
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)
mergify Bot pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
Robbert Hink @mergify
adjust for removed kibana security settings (#2315)
9bfad0e 
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)
dedemorton pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
@mergify Robbert Hink
adjust for removed kibana security settings (#2315) (#2318)
b494c5d 
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)

Co-authored-by: Robbert Hink <robbert.hink@elastic.co>
dedemorton pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
@mergify Robbert Hink
adjust for removed kibana security settings (#2315) (#2317)
b888d74 
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)

Co-authored-by: Robbert Hink <robbert.hink@elastic.co>
dedemorton pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
@mergify Robbert Hink
adjust for removed kibana security settings (#2315) (#2319)
4f10de8 
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)

Co-authored-by: Robbert Hink <robbert.hink@elastic.co>
dedemorton pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
@mergify Robbert Hink
adjust for removed kibana security settings (#2315) (#2320)
0ac1d76 
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)

Co-authored-by: Robbert Hink <robbert.hink@elastic.co>
dedemorton pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
@mergify Robbert Hink
adjust for removed kibana security settings (#2315) (#2321)
284840c 
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)

Co-authored-by: Robbert Hink <robbert.hink@elastic.co>
dedemorton pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
@mergify Robbert Hink
adjust for removed kibana security settings (#2315) (#2322)
434dd89 
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)

Co-authored-by: Robbert Hink <robbert.hink@elastic.co>
bmorelli25 pushed a commit to bmorelli25/ingest-docs that referenced this pull request Dec 19, 2022
Robbert Hink
adjust for removed kibana security settings (#2315)
6435c51 
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
Robbert Hink
adjust for removed kibana security settings (elastic#2315)
3d9c030 
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards
@linghengqian linghengqian mentioned this pull request Sep 27, 2024
Closed
@jbudz jbudz mentioned this pull request Oct 1, 2024
Closed
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
@watson @kibanamachine
Remove deprecated xpack.security.enabled config option (elastic#111681)
98cd834 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsullivan tsullivan tsullivan approved these changes
@jbudz jbudz jbudz approved these changes
@kpollich kpollich kpollich approved these changes
@YulNaumenko YulNaumenko YulNaumenko approved these changes
+2 more reviewers
@jportner jportner jportner approved these changes
@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@watson watson

Labels

backport:skip This PR does not require backporting release_note:breaking Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ignore xpack.security.enabled setting