Repository navigation
[7.17] Test config settings that are exposed to the browser (#129438) - #129857
Merged
Merged
Conversation
(cherry picked from commit 27ff7d3) # Conflicts: # .github/CODEOWNERS # packages/kbn-config-schema/src/index.ts
jportner
enabled auto-merge (squash)
April 9, 2022 15:00
added 3 commits
April 11, 2022 10:22
This is a partial backport of #111681, so the Kibana security plugin is enabled but Elasticsearch security is still disabled.
The exposed config keys are slightly different in the 7.17 branch.
The enterpriseSearch plugin does not have a required dependency on the security plugin in the 7.17 branch, so our bacported assertions for these tests needed to change accordingly.
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto7.17:Questions ?
Please refer to the Backport tool documentation