Repository navigation
fix heatmap sizing on dashboard - #13636
Merged
Merged
Conversation
Contributor
|
S3 ci issue jenkins, test this |
stacey-gammon
left a comment
There was a problem hiding this comment.
Could you add a test to catch this? If you add a heatmap to a dashboard, set the time range so that the bar is close to the right hand side, then resize the browser to make it narrower, then make sure that there are still bars visible, I think that should do the trick. lmk if you want help with that.
There was a problem hiding this comment.
Do you think it'd be overkill to add a comment in here, maybe with a link to the issue? If I was reading this as a developer I'd have no idea why the axes were reversed.
ppisljar
force-pushed
the
fix/heatmapSize
branch
from
August 29, 2017 09:01
d6d9a5c to
764d35b
Compare
Contributor
Author
|
jenkins, test this |
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Aug 29, 2017
* category axes should be rendered from last to first for heatmap to work correctly * adding a test
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Aug 29, 2017
* category axes should be rendered from last to first for heatmap to work correctly * adding a test
ppisljar
added a commit
that referenced
this pull request
Aug 29, 2017
ppisljar
added a commit
that referenced
this pull request
Aug 29, 2017
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* category axes should be rendered from last to first for heatmap to work correctly * adding a test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #13551