Skip to content

fix heatmap sizing on dashboard #13636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ppisljar merged 2 commits into from
Aug 29, 2017
Merged

fix heatmap sizing on dashboard #13636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6908872
category axes should be rendered from last to first for heatmap to wo…
ppisljar Aug 22, 2017
764d35b
adding a test
ppisljar Aug 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/ui/public/vislib/__tests__/visualizations/heatmap_chart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,15 @@ describe('Vislib Heatmap Chart Test Suite', function () {
vis.destroy();
});

it('category axes should be rendered in reverse order', () => {
const renderedCategoryAxes = vis.handler.renderArray.filter(item => {
return item.constructor && item.constructor.name === 'Axis' && item.axisConfig.get('type') === 'category';
});
expect(vis.handler.categoryAxes.length).to.equal(renderedCategoryAxes.length);
expect(vis.handler.categoryAxes[0].axisConfig.get('id')).to.equal(renderedCategoryAxes[1].axisConfig.get('id'));
expect(vis.handler.categoryAxes[1].axisConfig.get('id')).to.equal(renderedCategoryAxes[0].axisConfig.get('id'));
});

describe('addSquares method', function () {
it('should append rects', function () {
vis.handler.charts.forEach(function (chart) {
Expand Down
3 changes: 2 additions & 1 deletion src/ui/public/vislib/lib/handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ export function VisHandlerProvider(Private) {

this.renderArray = this.renderArray
.concat(this.valueAxes)
.concat(this.categoryAxes);
// category axes need to render in reverse order https://github.com/elastic/kibana/issues/13551
.concat(this.categoryAxes.slice().reverse());

// memoize so that the same function is returned every time,
// allowing us to remove/re-add the same function
Expand Down