Repository navigation
[8.8] Change kibana.alert.evaluation.threshold unit to microseconds (#158703) - #159013
Merged
Merged
Conversation
…c#158703) Resolves elastic#156255 Fixes elastic#158204 Partially reverts elastic#154801 [RFC Document](https://docs.google.com/document/d/1-O6-nqOedrjtTF9mHawd_u-vUdXu06KGI8ic5qNeQPQ/edit?usp=sharing) ## Summary This PR changes kibana.alert.evaluation.threshold unit to microseconds in AAD. |Case|Screenshot| |----|---| |Saved value in AAD|| |Should show correct information in flyout|| |Should show correct information on alert details page|| |Should show correct information in action message|| |Same unit for value and threshold in the alert table|| ## 🧪 How to test - Generate an APM Latency threshold alert - Check the threshold in - Alert's flyout - Alert's table - Alert details page (summary and chart) - Action generated by this alert (cherry picked from commit d13f884) # Conflicts: # x-pack/plugins/apm/public/components/alerting/ui_components/alert_details_app_section/index.tsx # x-pack/plugins/observability/public/components/alerts_flyout_body.tsx
Contributor
|
Pinging @elastic/apm-ui (Team:APM) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.8:Questions ?
Please refer to the Backport tool documentation