Repository navigation
Fix Visual Builder wrong color rules on multiple gauges - #27810
Merged
Merged
Conversation
Contributor
💚 Build Succeeded |
markov00
reviewed
Jan 7, 2019
markov00
left a comment
Contributor
There was a problem hiding this comment.
Code LGTM. I've tested locally the fix and now I can get the right color for each gauges.
Please add a functional test to validate this fix: something like:
- create a multi gauge tsvb
- check the color of all the gauges to be the same of the series (green)
- add a gauge bar color
greater than something - check if the gauges have the right color
Contributor
|
Pinging @elastic/kibana-app |
markov00
approved these changes
Jan 9, 2019
markov00
left a comment
Contributor
There was a problem hiding this comment.
Ok good to go. We will move the test to a different PR
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Jan 9, 2019
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Jan 9, 2019
sulemanof
added a commit
that referenced
this pull request
Jan 9, 2019
sulemanof
added a commit
that referenced
this pull request
Jan 9, 2019
This was referenced Jun 25, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #23181
The reason was in a series array:
undefinedvalue by [0] index in the array, and the data lays by [1] indexThe reason of such behavior is line 60 in
kibana\src\legacy\core_plugins\metrics\public\components\vis_with_splits.js:Any changes here could break an existing functionality, so I decided to affect the only gauge component. Now it works as expected and here how it looks after fix:
For maintainers