Skip to content

VisualBuilder Metric: Zero values ends in a changed behavior of the color rules - #39583

Merged
alexwizp merged 1 commit into
elastic:masterfrom
alexwizp:37958
Jun 27, 2019
Merged

alexwizp merged 1 commit into
elastic:masterfrom
alexwizp:37958

Conversation

@alexwizp

@alexwizp alexwizp commented Jun 25, 2019 •

Copy link
Copy Markdown
Contributor

Fix: #37958

Summary

Regression of #27810 #31455
Root cause: if execution of getLastValue(series[0].data) returns 0 we tried to get value from series[1].
Looks like wrong fix.

Checklist

For maintainers

@alexwizp
alexwizp requested review from a team, markov00 and sulemanof June 25, 2019 15:21
@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@TinaHeiligers TinaHeiligers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test this locally but the code looks fine.
LGTM
👍

@alexwizp
alexwizp merged commit 50a09e2 into elastic:master Jun 27, 2019
@alexwizp alexwizp added v7.3.0 v8.0.0 Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Jun 27, 2019
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app

@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

@alexwizp
alexwizp deleted the 37958 branch January 4, 2020 08:16
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.3.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VisualBuilder Metric: Zero values ends in a changed behavior of the color rules

4 participants