Repository navigation
Pipeline field formatting - #28746
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💔 Build Failed |
ppisljar
force-pushed
the
pipeline/fieldFormatting
branch
from
January 15, 2019 10:03
809fa3b to
8421ab5
Compare
2 tasks
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
8 tasks done
lukeelmers
requested changes
Jan 16, 2019
lukeelmers
left a comment
Contributor
There was a problem hiding this comment.
@ppisljar I feel like I just ran a marathon (In a good way!) 😉
Added a handful of comments: some nits, some questions on structure, and only a couple items that are potential buggy edge cases. Overall though, this is great -- it all feels way cleaner without AggConfigs hanging around everywhere 😄
I've also done some initial testing locally (Chrome OSX) and so far not noticing any obvious issues.
Ping me if you want to sync on any of these notes!
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
markov00
approved these changes
Jan 17, 2019
markov00
left a comment
Contributor
There was a problem hiding this comment.
Code LGTM. Tested the main functionalities, fiters and tooltips.
I've left just a minor comment
| } else { | ||
| title = aggConfig.makeLabel(); | ||
| } | ||
| if (!isPercentageMode) value = this._getFormattedValue(formatter, value, 'html'); |
Contributor
There was a problem hiding this comment.
can you move this as the else of the previous if statement?
Contributor
💚 Build Succeeded |
lukeelmers
approved these changes
Jan 17, 2019
This was referenced Mar 28, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handling field formatting in the expressions
all visualizations now get formatting options passed in as part of the configuration
bottom line: aggConfig is no longer necesarry in any response handlers or any visualization.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately