Repository navigation
Surface vis loader errors in the UI. - #30594
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app |
This comment has been minimized.
This comment has been minimized.
lukeelmers
force-pushed
the
fix/vis-loader-errors
branch
from
February 11, 2019 21:07
5feb58c to
0f551b9
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
lukeelmers
force-pushed
the
fix/vis-loader-errors
branch
from
February 15, 2019 17:23
0f551b9 to
6c703b6
Compare
Contributor
💚 Build Succeeded |
ppisljar
approved these changes
Feb 21, 2019
ppisljar
left a comment
Contributor
There was a problem hiding this comment.
LGTM, tested on chrome linux
emmacunningham
approved these changes
Feb 22, 2019
emmacunningham
left a comment
There was a problem hiding this comment.
tested locally on Firefox (OS X); code LGTM
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Feb 22, 2019
lukeelmers
added a commit
that referenced
this pull request
Feb 22, 2019
lukeelmers
added a commit
that referenced
this pull request
Feb 22, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29900
Fixes issue where errors were not caught and displayed in the UI when using the pipeline data loader.
I pulled the error handling logic out into a function that can be shared between
VisualizeDataLoaderandPipelineDataLoader.Notes for reviewers: