Skip to content

[TSVB] Make markdown across Kibana consistent - #31890

Merged
alexwizp merged 1 commit into
elastic:masterfrom
alexwizp:14436
Feb 25, 2019
Merged

alexwizp merged 1 commit into
elastic:masterfrom
alexwizp:14436

Conversation

@alexwizp

@alexwizp alexwizp commented Feb 25, 2019 •

Copy link
Copy Markdown
Contributor

Summary

Fix: #14436. GFMD (GitHub Flavored Markdown Spec) checked

Release Summary: TSVB now uses the same markdown parser than the Markdown visualization.

Before:
before_1

After:
after_1

Checklist

For maintainers

@markov00 markov00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally and now it display nicely!
Please can you change the title of this PR to include TSVB? We still have some components that use a different markdown implementation MarkdownSimple and I think it's better keep that title when we will finally have a single implementation across kibana :)

@alexwizp alexwizp changed the title Make markdown across Kibana consistent [TSVB] Make markdown across Kibana consistent Feb 25, 2019
@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@alexwizp alexwizp added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Feb 25, 2019
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app

@timroes timroes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@alexwizp
alexwizp merged commit dc59a74 into elastic:master Feb 25, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 25, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 25, 2019
@alexwizp
alexwizp deleted the 14436 branch January 4, 2020 08:12
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:TSVB TSVB (Time Series Visual Builder) release_note:enhancement Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.0.0 v7.2.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants