Skip to content

[TSVB] Make markdown across Kibana consistent #31890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexwizp merged 1 commit into from
Feb 25, 2019
Merged

[TSVB] Make markdown across Kibana consistent #31890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/legacy/core_plugins/metrics/public/components/vis_types/markdown/vis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,23 @@
* specific language governing permissions and limitations
* under the License.
*/

import PropTypes from 'prop-types';
import React from 'react';
import classNames from 'classnames';
import { isBackgroundInverted } from '../../../../common/set_is_reversed';
import _ from 'lodash';
import Markdown from 'react-markdown';
import uuid from 'uuid';
import { get } from 'lodash';
import { Markdown } from 'ui/markdown/markdown';

import ErrorComponent from '../../error';
import replaceVars from '../../lib/replace_vars';
import convertSeriesToVars from '../../lib/convert_series_to_vars';
import ErrorComponent from '../../error';
import uuid from 'uuid';
import { isBackgroundInverted } from '../../../../common/set_is_reversed';

const getMarkdownId = id => `markdown-${id}`;

function MarkdownVisualization(props) {
const { backgroundColor, model, visData, dateFormat } = props;
const series = _.get(visData, `${model.id}.series`, []);
const series = get(visData, `${model.id}.series`, []);
const variables = convertSeriesToVars(series, model, dateFormat, props.getConfig);
const markdownElementId = getMarkdownId(uuid.v1());

Expand Down Expand Up @@ -74,7 +74,7 @@ function MarkdownVisualization(props) {
{markdownError && <ErrorComponent error={markdownError} />}
<style type="text/css">{markdownCss}</style>
<div className={contentClasses}>
<div id={markdownElementId}>{!markdownError && <Markdown escapeHtml={true} source={markdownSource} />}</div>
<div id={markdownElementId}>{!markdownError && <Markdown markdown={markdownSource} />}</div>
</div>
</div>
);
Expand Down