Repository navigation
Exclude usage stats when exclude_usage flag is specified - #35691
Merged
Merged
Conversation
pickypg
reviewed
Apr 26, 2019
pickypg
left a comment
Member
There was a problem hiding this comment.
Workflow LGTM. Creative Promise usage.
exclude_usage flag is specifiedexclude_usage flag is specified
Bamieh
approved these changes
Apr 26, 2019
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins, test this |
ycombinator
force-pushed
the
kb-stats-exclude-usage
branch
from
April 27, 2019 00:17
560c673 to
dca4cde
Compare
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
ycombinator
added a commit
to ycombinator/kibana
that referenced
this pull request
Apr 27, 2019
…5691) * Exclude usage stats when `exclude_usage` flag is specified * Entirely excluding the usage key altogether * Adding API integration test * Fixing param name in comment + adding more info to comment * Fix API test copy-pasta * Fixing test assertion syntax
ycombinator
added a commit
to ycombinator/kibana
that referenced
this pull request
Apr 27, 2019
…5691) * Exclude usage stats when `exclude_usage` flag is specified * Entirely excluding the usage key altogether * Adding API integration test * Fixing param name in comment + adding more info to comment * Fix API test copy-pasta * Fixing test assertion syntax
ycombinator
added a commit
to ycombinator/kibana
that referenced
this pull request
Apr 27, 2019
…5691) * Exclude usage stats when `exclude_usage` flag is specified * Entirely excluding the usage key altogether * Adding API integration test * Fixing param name in comment + adding more info to comment * Fix API test copy-pasta * Fixing test assertion syntax
This was referenced Apr 27, 2019
ycombinator
added a commit
that referenced
this pull request
Apr 27, 2019
) (#35701) * Exclude usage stats when `exclude_usage` flag is specified * Entirely excluding the usage key altogether * Adding API integration test * Fixing param name in comment + adding more info to comment * Fix API test copy-pasta * Fixing test assertion syntax
ycombinator
added a commit
that referenced
this pull request
Apr 27, 2019
) (#35700) * Exclude usage stats when `exclude_usage` flag is specified * Entirely excluding the usage key altogether * Adding API integration test * Fixing param name in comment + adding more info to comment * Fix API test copy-pasta * Fixing test assertion syntax
ycombinator
added a commit
that referenced
this pull request
Apr 28, 2019
) (#35702) * Exclude usage stats when `exclude_usage` flag is specified * Entirely excluding the usage key altogether * Adding API integration test * Fixing param name in comment + adding more info to comment * Fix API test copy-pasta * Fixing test assertion syntax
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…5691) * Exclude usage stats when `exclude_usage` flag is specified * Entirely excluding the usage key altogether * Adding API integration test * Fixing param name in comment + adding more info to comment * Fix API test copy-pasta * Fixing test assertion syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #34609.
This PR augments the
GET /api/statsAPI to take an optionalexclude_usageflag. The default value of this flag isfalse. When this flag is set, theusagepart of the API response will be... 🥁 ... excluded from the response.