Repository navigation
[Maps] Support multiple basemap styles - #36074
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-gis |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
thomasneirynck
self-requested a review
May 7, 2019 21:18
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
thomasneirynck
left a comment
Contributor
There was a problem hiding this comment.
This is great thanks. After discussion in person, let's make two changes:
- Remove introduction of desaturation in region-maps. We want to deprecate this feature anyway., as well as migrate away of any angular code in Kibana. This is introducing this desaturation in a new place, and introduces new angular code.
- Mimic old behavior in coordinate maps and region maps, but use the new EMS services
- only show single EMS option in the base-layer dropdown. This will be "Road map"
- modify service_settings to automagically select the corresponding metadata
- select the right URL based on desaturation/dark theming selection
- add similar methods for retrieving zoom and attribution
- no mods to Vega
Mods to ems_client and maps-app are just right. We want to offer just a drop-down there with the new options just listed out.
Contributor
|
Can you update the logic in getInitialLayers to default to the dark theme base layer when Kibana is configured for dark theme. That way, when users create a new map in dark theme, the dark themed tiles are used by default. |
thomasneirynck
self-requested a review
May 9, 2019 15:42
thomasneirynck
self-requested a review
May 17, 2019 20:37
…sualizations" This reverts commit c382ee3.
Contributor
💚 Build Succeeded |
Contributor
There was a problem hiding this comment.
I think we're there-ish. I also verified WMS and self-hosted (map.tilemap.* in kibana.yml) are working correctly, something I hadn't done earlier.
A few things:
- update Vega too to use the server-config https://github.com/elastic/kibana/pull/36074/files#r285623995
- I'm on the fence on the following one. There will be a short flicker of the default map before loading the correct map. This is a bug on master regardless I believe, but the culprit seems to be here:
https://github.com/thomasneirynck/kibana/blob/7b4d09e4a2d91b857613ac41f29e608ad6d64bcb/src/legacy/core_plugins/tile_map/public/base_maps_visualization.js#L162
I'm wondering if we should just remove that line altogether (?). I can't recall now why this is in there to begin with.
This resolves the issue where the EMS basemap is loaded twice due to differences in the service setting options.
Contributor
💚 Build Succeeded |
thomasneirynck
self-requested a review
May 20, 2019 21:56
Contributor
Author
|
jenkins, test this |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
nickpeihl
added a commit
to nickpeihl/kibana
that referenced
this pull request
May 22, 2019
nickpeihl
added a commit
that referenced
this pull request
May 22, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Elastic Maps Service will soon be publishing a new tiles manifest with additional styles, including dark and desaturated road maps. This PR forms the groundwork for updating the geospatial visualizations in Kibana to use the new manifest. This is a work in progress and more items may be added to the checklist.
Maps
Region Maps and Coordinate Maps
Vega Maps