Skip to content

[Uptime] Fix PingList pagination - #61481

Merged
justinkambic merged 2 commits into
elastic:masterfrom
justinkambic:uptime_ping-pagination
Mar 27, 2020
Merged

justinkambic merged 2 commits into
elastic:masterfrom
justinkambic:uptime_ping-pagination

Conversation

@justinkambic

Copy link
Copy Markdown
Contributor

Summary

Fixes #61315.

The PingList component in Uptime has a broken pagination experience, which can lead to users being misled that they only have n items when really they have m items where n is the number of rows on the page and m is the total document count for the given monitor ID.

This request aims to fix that by updating the UI, API, and ES query responsible for fetching and rendering this information.

Testing this PR

  1. Go to detail page for a monitor that has at least ~1000 documents.
  2. Change the page size to the various values supplied, and make sure the numbers you see are accurate.
  3. Change the page selections and make sure they continue to be sorted by timestamp appropriately.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience release_note:fix v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0 v7.8.0 labels Mar 26, 2020
@justinkambic justinkambic self-assigned this Mar 26, 2020
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibanamachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@justinkambic
justinkambic merged commit 1da53ed into elastic:master Mar 27, 2020
justinkambic added a commit to justinkambic/kibana that referenced this pull request Mar 27, 2020
* Add pagination.

* Update test files.
justinkambic added a commit to justinkambic/kibana that referenced this pull request Mar 27, 2020
* Add pagination.

* Update test files.
justinkambic added a commit that referenced this pull request Mar 28, 2020
* Add pagination.

* Update test files.
justinkambic added a commit that referenced this pull request Mar 28, 2020
* Add pagination.

* Update test files.
@justinkambic

Copy link
Copy Markdown
Contributor Author

@justinkambic
justinkambic deleted the uptime_ping-pagination branch March 28, 2020 00:08
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
* Add pagination.

* Update test files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0 v7.8.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Uptime] Pagination on ping list is broken

4 participants