Repository navigation
[Uptime] Fix PingList pagination - #61481
Merged
justinkambic merged 2 commits intoMar 27, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Mar 27, 2020
* Add pagination. * Update test files.
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Mar 27, 2020
* Add pagination. * Update test files.
justinkambic
added a commit
that referenced
this pull request
Mar 28, 2020
justinkambic
added a commit
that referenced
this pull request
Mar 28, 2020
Contributor
Author
|
Backported to: |
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* Add pagination. * Update test files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #61315.
The PingList component in Uptime has a broken pagination experience, which can lead to users being misled that they only have
nitems when really they havemitems wherenis the number of rows on the page andmis the total document count for the given monitor ID.This request aims to fix that by updating the UI, API, and ES query responsible for fetching and rendering this information.
Testing this PR
Checklist
Delete any items that are not applicable to this PR.
For maintainers