Repository navigation
[kbnUrl] reload the route when going from "" to "/" - #8815
Merged
Merged
Conversation
In timelion the initial route is set to '' which might not be perfectly correct, but works fine. When clicking the "new" button for the first time this causes the route to update from '' to '/', which the kbnUrl service assumes will cause a route change and does not try to force the route to reload. Instead, the router sees this as a noop and the change to the route has no effect unless you click the "new" button a second time.
| if (!route) return false; | ||
|
|
||
| if (next.path !== prev.path) return false; | ||
| // for the purposes of determining wether there will be a reload, |
There was a problem hiding this comment.
wether = whether :) (fun fact of the day, I now know what to call a castrated ram)
There was a problem hiding this comment.
If '_shouldAutoReload' returns true does that mean 'angular should automatically reload so we don't have to manually force a reload', or 'angular will not auto reload, so we should force a reload'? It seems like it should be the former, otherwise it's not really an "auto" reload, it's a "manual" reload, but I think it's the latter, right? I suppose you could argue the semantics either way, but because the name of the function is a bit ambiguous (IMO), I think something along the lines of the comment you left in the conversation of this PR would be helpful in the actual code, or maybe just expanding on the comment you left here.
Contributor
Author
|
@stacey-gammon @thomasneirynck would you mind taking another look at this? |
thomasneirynck
approved these changes
Nov 4, 2016
| // for the purposes of determining whether the router will | ||
| // automatically be reloading, '' and '/' are equal | ||
| const nextPath = next.path || '/'; | ||
| const prevPath = prev.path || '/'; |
Contributor
There was a problem hiding this comment.
this made me blink. could be JS interview question ;)
elastic-jasper
added a commit
that referenced
this pull request
Nov 7, 2016
Backports PR #8815 **Commit 1:** [kbnUrl] reload the route when going from "" to "/" In timelion the initial route is set to '' which might not be perfectly correct, but works fine. When clicking the "new" button for the first time this causes the route to update from '' to '/', which the kbnUrl service assumes will cause a route change and does not try to force the route to reload. Instead, the router sees this as a noop and the change to the route has no effect unless you click the "new" button a second time. * Original sha: a7304ec * Authored by spalger <email@spalger.com> on 2016-10-24T20:43:40Z **Commit 2:** [kbnUrl] clarify the purpose _shouldAutoReload * Original sha: fbfbae3 * Authored by spalger <email@spalger.com> on 2016-10-24T23:45:52Z **Commit 3:** [kbnUrl] fix the tests * Original sha: cc9c2f6 * Authored by spalger <email@spalger.com> on 2016-10-25T00:31:22Z
spalger
pushed a commit
that referenced
this pull request
Nov 8, 2016
Backports PR #8815 **Commit 1:** [kbnUrl] reload the route when going from "" to "/" In timelion the initial route is set to '' which might not be perfectly correct, but works fine. When clicking the "new" button for the first time this causes the route to update from '' to '/', which the kbnUrl service assumes will cause a route change and does not try to force the route to reload. Instead, the router sees this as a noop and the change to the route has no effect unless you click the "new" button a second time. * Original sha: a7304ec * Authored by spalger <email@spalger.com> on 2016-10-24T20:43:40Z **Commit 2:** [kbnUrl] clarify the purpose _shouldAutoReload * Original sha: fbfbae3 * Authored by spalger <email@spalger.com> on 2016-10-24T23:45:52Z **Commit 3:** [kbnUrl] fix the tests * Original sha: cc9c2f6 * Authored by spalger <email@spalger.com> on 2016-10-25T00:31:22Z
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Nov 10, 2016
* [kbnUrl] reload the route when going from "" to "/" In timelion the initial route is set to '' which might not be perfectly correct, but works fine. When clicking the "new" button for the first time this causes the route to update from '' to '/', which the kbnUrl service assumes will cause a route change and does not try to force the route to reload. Instead, the router sees this as a noop and the change to the route has no effect unless you click the "new" button a second time. * [kbnUrl] clarify the purpose _shouldAutoReload * [kbnUrl] fix the tests
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Backports PR elastic#8815 **Commit 1:** [kbnUrl] reload the route when going from "" to "/" In timelion the initial route is set to '' which might not be perfectly correct, but works fine. When clicking the "new" button for the first time this causes the route to update from '' to '/', which the kbnUrl service assumes will cause a route change and does not try to force the route to reload. Instead, the router sees this as a noop and the change to the route has no effect unless you click the "new" button a second time. * Original sha: a7304ec * Authored by spalger <email@spalger.com> on 2016-10-24T20:43:40Z **Commit 2:** [kbnUrl] clarify the purpose _shouldAutoReload * Original sha: fbfbae3 * Authored by spalger <email@spalger.com> on 2016-10-24T23:45:52Z **Commit 3:** [kbnUrl] fix the tests * Original sha: cc9c2f6 * Authored by spalger <email@spalger.com> on 2016-10-25T00:31:22Z Former-commit-id: fc8cef7
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* [kbnUrl] reload the route when going from "" to "/" In timelion the initial route is set to '' which might not be perfectly correct, but works fine. When clicking the "new" button for the first time this causes the route to update from '' to '/', which the kbnUrl service assumes will cause a route change and does not try to force the route to reload. Instead, the router sees this as a noop and the change to the route has no effect unless you click the "new" button a second time. * [kbnUrl] clarify the purpose _shouldAutoReload * [kbnUrl] fix the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8816
In timelion the initial route is set to '' which might not be perfectly correct, but works fine. When clicking the "new" button for the first time this causes the route to update from '' to '/', which the kbnUrl service assumes will cause a route change and does not try to force the route to reload. Instead, the router sees this as a noop and the change to the route has no effect unless you click the "new" button a second time.