Repository navigation
Conversation
yaauie
requested review from
elasticsearch-bot
and removed request for
elasticsearch-bot
April 2, 2019 17:17
Co-Authored-By: yaauie <yaauie@users.noreply.github.com>
| # Instances of `DeprecatedSetting` can be registered, but will fail with helpful guidance when encountering any | ||
| # configuration that attempts to explicitly set the value. They should be used in the Major version immediately | ||
| # following a deprecation to assist users who are porting forward configurations. | ||
| class DeprecatedSetting < Setting |
Contributor
colinsurprenant
approved these changes
Apr 2, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 2, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 2, 2019
Co-Authored-By: yaauie <yaauie@users.noreply.github.com> Fixes #10623
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 2, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 2, 2019
Co-Authored-By: yaauie <yaauie@users.noreply.github.com> Fixes #10623
Member
Author
|
Unless we have another 7.0.0 RC (which is unlikely at this point), this will have missed the boat. This will be available in |
Member
|
@yaauie it seems this missed the master branch, and it's only present in 7.x, please "forward" port it unless you see a reason not to have DeprecatedSetting in 8.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge targets:
7.x,7.0Resolves #10616