Conversation
dddududu
requested review from
eknabevcc,
esmini and
slundel6
as code owners
September 21, 2026 09:38
dddududu
force-pushed
the
fix/init-action-ordering
branch
from
September 21, 2026 10:30
1392603 to
c7d8974
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two OpenSCENARIO Init-section semantics issues:
TeleportActionmust not claim longitudinal or lateral control domains.Closes #778
Closes #779
Changes
StoryBoard::Stepuntil after the Init global, user-defined, and private actions have stepped.TeleportActiontoDOMAIN_MASK_NONE, matching the OpenSCENARIO action-domain table..xoscregression scenario that combines an InitTeleportAction, an Init stepSpeedAction, and an immediately triggered eventSpeedAction.TeleportActiondomain mask and smoke-test coverage for the Init-action ordering.Testing
19d26b6usinginit_instantaneous_actions.xosc:Stopping Init Car TeleportAction on conflicting Lateral & Longitudinal domain(s)Stopping Init Car LongitudinalAction on conflicting Longitudinal domain(s)EventSpeedActionstarts and noStopping Init Carconflict warning is emitted.TeleportActionTest.DoesNotClaimLongitudinalOrLateralControl: passed.TestSuite.test_init_instantaneous_actions: passed.git diff --check, clang-format 15.0.7, Cppcheck 2.17.1, and a minimal MSVC build: passed.