Skip to content

Issues #778 and #779 - #846 - #846

Open
dddududu wants to merge 1 commit into
esmini:devfrom
dddududu:fix/init-action-ordering
Open

dddududu wants to merge 1 commit into
esmini:devfrom
dddududu:fix/init-action-ordering

Conversation

@dddududu

@dddududu dddududu commented Sep 21, 2026 •

Copy link
Copy Markdown

Description

This PR fixes two OpenSCENARIO Init-section semantics issues:

  • Init actions must complete before storyboard triggers can start competing event actions.
  • TeleportAction must not claim longitudinal or lateral control domains.

Closes #778
Closes #779

Changes

  • Move trigger evaluation in StoryBoard::Step until after the Init global, user-defined, and private actions have stepped.
  • Set TeleportAction to DOMAIN_MASK_NONE, matching the OpenSCENARIO action-domain table.
  • Add a minimal .xosc regression scenario that combines an Init TeleportAction, an Init step SpeedAction, and an immediately triggered event SpeedAction.
  • Add GTest coverage for the TeleportAction domain mask and smoke-test coverage for the Init-action ordering.

Testing

  1. Reproduced both failures against 19d26b6 using init_instantaneous_actions.xosc:
    • Stopping Init Car TeleportAction on conflicting Lateral & Longitudinal domain(s)
    • Stopping Init Car LongitudinalAction on conflicting Longitudinal domain(s)
  2. Verified the same scenario after the fix: both Init actions complete before EventSpeedAction starts and no Stopping Init Car conflict warning is emitted.
  3. Ran TeleportActionTest.DoesNotClaimLongitudinalOrLateralControl: passed.
  4. Ran TestSuite.test_init_instantaneous_actions: passed.
  5. Ran XML/Python syntax checks, git diff --check, clang-format 15.0.7, Cppcheck 2.17.1, and a minimal MSVC build: passed.
  6. Ran a real OpenSCENARIO/OpenDRIVE scenario from the local simulation dataset: completed successfully.

@dddududu
dddududu changed the base branch from master to dev September 21, 2026 10:08
@dddududu
dddududu force-pushed the fix/init-action-ordering branch from 1392603 to c7d8974 Compare September 21, 2026 10:30
@dddududu dddududu changed the title Fix Init action ordering and Teleport domains Issues #778 and #779 - #846 Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant