Skip to content

feat: enable detectInadmissibleWorkUnits by default - #51

Merged
janzak-dev merged 2 commits into
mainfrom
feature/enable_detect_inadmissible_workunits
Jun 19, 2026
Merged

janzak-dev merged 2 commits into
mainfrom
feature/enable_detect_inadmissible_workunits

Conversation

@janzak-dev

Copy link
Copy Markdown
Collaborator

Enable detectInadmissibleWorkUnits by default in both reconciler config and helm values.

I've validated that this works:
image

Enable detectInadmissibleWorkUnits by default in both reconciler config
and helm values.

TAG=agy
CONV=b2cd03bf-62b1-4dfe-b062-74efe8f03ca5

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the detectInadmissibleWorkUnits flag by default in both the reconciler configuration and the Helm values. However, enabling this flag activates a code path with a potential nil pointer dereference panic in updateWorkUnitExecutionUpdateWithInadmissibleReason when update is initially nil, as update.UpdateMask would also be nil. It is recommended to initialize update.UpdateMask before appending to its paths.

Comment thread cmd/reconciler/config.go Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants