Repository navigation
feat: enable detectInadmissibleWorkUnits by default - #51
Merged
Merged
Conversation
Enable detectInadmissibleWorkUnits by default in both reconciler config and helm values. TAG=agy CONV=b2cd03bf-62b1-4dfe-b062-74efe8f03ca5
There was a problem hiding this comment.
Code Review
This pull request enables the detectInadmissibleWorkUnits flag by default in both the reconciler configuration and the Helm values. However, enabling this flag activates a code path with a potential nil pointer dereference panic in updateWorkUnitExecutionUpdateWithInadmissibleReason when update is initially nil, as update.UpdateMask would also be nil. It is recommended to initialize update.UpdateMask before appending to its paths.
andrzejfudro
approved these changes
Jun 18, 2026
VLukiantsev
approved these changes
Jun 18, 2026
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable detectInadmissibleWorkUnits by default in both reconciler config and helm values.
I've validated that this works:
