Skip to content

feat(deploy): enable ROD and admin panel by default - #981

Merged
andrzejfudro merged 2 commits into
mainfrom
feat/default-enable-rod-admin-panel
Sep 25, 2026
Merged

andrzejfudro merged 2 commits into
mainfrom
feat/default-enable-rod-admin-panel

Conversation

@andrzejfudro

@andrzejfudro andrzejfudro commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Enables the ROD data provider and the Admin Panel (health service) by default on GKE deployments. Metrics ingestion and the dashboard service stay off, since they need extra BYO components.

Key Changes

  • deploy/ctk_v2/xmanager-cloud.yaml, deploy/helm/values.yaml: health_service_deployment_enabled / rod_deployment_enabled now default to true.
  • deploy/ctk_v2/xmc-deployment-template.yaml: both switches listed explicitly as true.
  • deploy/local/xmanager-cloud-local-template.yaml: KinD keeps both explicitly false.
  • tools/dev_env/config.py (+ tests): ROD / health service fallbacks set to True to match.
  • cmd/ui/server.py, cmd/ui/generate_config.sh (+ tests): XMC_ADMIN_PANEL_ENABLED / XMC_RESOURCE_DASHBOARD_ENABLED fallbacks set to true, following the feat: enable detectInadmissibleWorkUnits by default #51 precedent of flipping code and Helm together. XMC_PERFORMANCE_DASHBOARD_ENABLED stays false.
  • READMEs: flag docs updated. The dev_env flag table was also corrected: enable_metrics defaults to false, and health/dashboard services depend on flags rather than being base services.

Assumptions

  • Admin Panel is gated by the health service deployment flag. There is no separate flag, per ui-deployment.yaml.
  • feature_flag_service.ts still treats a missing flag as disabled. That only matters if config.js is not served at all.
  • KinD keeps the health service disabled along with ROD. I haven't confirmed it runs locally without GCP; flip it if the Admin Panel should work in KinD.
  • Existing environments whose config doesn't set rod_deployment_enabled will get ROD on their next rollout. gke-upgrade does not apply the compute group, so it won't create the ROD Workload Identity binding. Those environments need gke-deploy, or should set rod_deployment_enabled: false.

Verification & Testing

  • Commands Executed: python3 -m unittest discover -s tools/dev_env -p '*_test.py' -t .
  • Coverage & Test Status: 325/325 pass.
  • GKE deploy

TAG=agy
CONV=8d697701-a8b1-4805-8fb5-3527e051bd15

Flip the default for the ROD data provider and the health service (which
gates the Admin Panel in the UI) to enabled across the CTK blueprint,
Helm chart, dev_env tooling, and the UI runtime config fallbacks
(server.py / generate_config.sh). Metrics ingestion and the dashboard
service stay disabled because they require additional BYO components
(ClickHouse / Redpanda).

Local KinD template keeps both services explicitly disabled.

Fixes b/565657962

TAG=agy
CONV=8d697701-a8b1-4805-8fb5-3527e051bd15

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default settings for several feature flags, enabling the admin panel, resource dashboard, ROD data provider, and health service by default across configuration scripts, deployment templates, local development tools, and tests. The feedback highlights a behavioral discrepancy between server.py and generate_config.sh when handling empty environment variables, and recommends improving test assertions in config_test.py to properly verify YAML overrides now that the default values have changed.

Comment thread cmd/ui/server.py Resolved
Comment thread tools/dev_env/config_test.py Resolved
health_service_deployment_enabled now defaults to true, so asserting it
is enabled when the YAML sets true no longer exercises the override.
Set it to false and assert the service is absent.

Comment link: #981 (comment)

TAG=agy
CONV=8d697701-a8b1-4805-8fb5-3527e051bd15
@andrzejfudro
andrzejfudro marked this pull request as ready for review September 24, 2026 16:00
@andrzejfudro
andrzejfudro added this pull request to the merge queue Sep 25, 2026
Merged via the queue into main with commit 3467a47 Sep 25, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants