Repository navigation
feat(deploy): enable ROD and admin panel by default - #981
Merged
Merged
Conversation
Flip the default for the ROD data provider and the health service (which gates the Admin Panel in the UI) to enabled across the CTK blueprint, Helm chart, dev_env tooling, and the UI runtime config fallbacks (server.py / generate_config.sh). Metrics ingestion and the dashboard service stay disabled because they require additional BYO components (ClickHouse / Redpanda). Local KinD template keeps both services explicitly disabled. Fixes b/565657962 TAG=agy CONV=8d697701-a8b1-4805-8fb5-3527e051bd15
There was a problem hiding this comment.
Code Review
This pull request updates the default settings for several feature flags, enabling the admin panel, resource dashboard, ROD data provider, and health service by default across configuration scripts, deployment templates, local development tools, and tests. The feedback highlights a behavioral discrepancy between server.py and generate_config.sh when handling empty environment variables, and recommends improving test assertions in config_test.py to properly verify YAML overrides now that the default values have changed.
health_service_deployment_enabled now defaults to true, so asserting it is enabled when the YAML sets true no longer exercises the override. Set it to false and assert the service is absent. Comment link: #981 (comment) TAG=agy CONV=8d697701-a8b1-4805-8fb5-3527e051bd15
andrzejfudro
marked this pull request as ready for review
September 24, 2026 16:00
andrzejfudro
enabled auto-merge
September 24, 2026 16:00
janzak-dev
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables the ROD data provider and the Admin Panel (health service) by default on GKE deployments. Metrics ingestion and the dashboard service stay off, since they need extra BYO components.
Key Changes
deploy/ctk_v2/xmanager-cloud.yaml,deploy/helm/values.yaml:health_service_deployment_enabled/rod_deployment_enablednow default totrue.deploy/ctk_v2/xmc-deployment-template.yaml: both switches listed explicitly astrue.deploy/local/xmanager-cloud-local-template.yaml: KinD keeps both explicitlyfalse.tools/dev_env/config.py(+ tests): ROD / health service fallbacks set toTrueto match.cmd/ui/server.py,cmd/ui/generate_config.sh(+ tests):XMC_ADMIN_PANEL_ENABLED/XMC_RESOURCE_DASHBOARD_ENABLEDfallbacks set totrue, following the feat: enable detectInadmissibleWorkUnits by default #51 precedent of flipping code and Helm together.XMC_PERFORMANCE_DASHBOARD_ENABLEDstaysfalse.enable_metricsdefaults tofalse, and health/dashboard services depend on flags rather than being base services.Assumptions
ui-deployment.yaml.feature_flag_service.tsstill treats a missing flag as disabled. That only matters ifconfig.jsis not served at all.rod_deployment_enabledwill get ROD on their next rollout.gke-upgradedoes not apply thecomputegroup, so it won't create the ROD Workload Identity binding. Those environments needgke-deploy, or should setrod_deployment_enabled: false.Verification & Testing
python3 -m unittest discover -s tools/dev_env -p '*_test.py' -t .TAG=agy
CONV=8d697701-a8b1-4805-8fb5-3527e051bd15