Skip to content

feat: new docs theme and daisyui #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
megatank58 merged 1 commit into from
Feb 13, 2022
Merged

feat: new docs theme and daisyui #5

megatank58 merged 1 commit into from
Feb 13, 2022

Conversation

@megatank58
Copy link
Contributor

@megatank58 megatank58 commented Feb 6, 2022 •
edited
Loading

This pull request is not meant for review or merge yet.

Conflicts will not be resolved and this branch will be force pushing to main, any other PRs are halt till this is merged

@netlify
Copy link

netlify bot commented Feb 6, 2022 •
edited
Loading

✔️ Deploy Preview for gominima ready!

🔨 Explore the source changes: 5e5ceb7

🔍 Inspect the deploy log: https://app.netlify.com/sites/gominima/deploys/6208cc27480a0d0007f05950

😎 Browse the preview: https://deploy-preview-5--gominima.netlify.app/

@savioxavier savioxavier mentioned this pull request Feb 8, 2022
Closed
savioxavier
savioxavier approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@savioxavier savioxavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, might tweak some stuff a bit in later commits.

@megatank58
Copy link
Contributor Author

megatank58 commented Feb 8, 2022

We will most probably unless urgent not be doing any commits to website regarding the core style and core design of the website so if you have any suggestions please drop em here

@savioxavier
Copy link
Member

savioxavier commented Feb 8, 2022 •
edited
Loading

We will most probably unless urgent not be doing any commits to website regarding the core style and core design of the website so if you have any suggestions please drop em here

Since Minima's core color scheme is blue (derived from its logo), we might have to change the green to blue, just to be consistent. We can keep it green, however, but that would require a complete overhaul of Minima's branding.

The font, maybe? It's currently the default font and it doesn't look too good on an Android device.

Improper heading styles? The texts look a bit bold to me. Also, the padding might need a fix, a little bit of breathing space, more like.

Also, there are a few responsiveness issues with different viewport (I tested it out on Responsively App) so that should be taken care of.

In addition, the background and color schemes of the code snippets might need to be fixed. The syntax highlighting looks relatively dull compared to the website, plus the code snippet background feels weird in a dark-modded website such as this. (Just refreshed the site now and it's alright)

Other than those, it looks pretty good to me!

@apoorvcodes apoorvcodes self-requested a review February 8, 2022 15:13
apoorvcodes
apoorvcodes requested changes Feb 8, 2022
View reviewed changes
Copy link
Member

@apoorvcodes apoorvcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the code block themes to dracula?

@savioxavier savioxavier self-requested a review February 8, 2022 15:18
@apoorvcodes
Copy link
Member

apoorvcodes commented Feb 10, 2022

@megatank58 eta for the pull

@megatank58
Copy link
Contributor Author

megatank58 commented Feb 10, 2022

@megatank58 eta for the pull

when it's ready

@megatank58
Copy link
Contributor Author

megatank58 commented Feb 10, 2022 •
edited
Loading

Summary of what's left to be done:

  • Add "Functions" section to /docs/main/struct/:struct
  • Add /docs/main/func/:func page (based on the previous mentioned section)
  • Add theme changer using a drop down in navbar or a button
  • Change the sidebar to use a different unicode

@megatank58 megatank58 marked this pull request as ready for review February 13, 2022 08:54
@megatank58
Copy link
Contributor Author

megatank58 commented Feb 13, 2022 •
edited
Loading

@savioxavier @apoorvcodes review

Conflicts will not be merged, the branch will be force pushed at once to main

apoorvcodes
apoorvcodes approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@apoorvcodes apoorvcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@megatank58 megatank58 closed this Feb 13, 2022
@megatank58
Copy link
Contributor Author

megatank58 commented Feb 13, 2022

Force pushed to main! 🎉

@megatank58 megatank58 deleted the next branch February 13, 2022 09:17
@megatank58 megatank58 restored the next branch February 13, 2022 09:19
@megatank58 megatank58 reopened this Feb 13, 2022
@megatank58 megatank58 merged commit f97ff50 into gominima:main Feb 13, 2022
@megatank58 megatank58 deleted the next branch February 13, 2022 09:20
savioxavier
savioxavier reviewed Feb 13, 2022
View reviewed changes
Copy link
Member

@savioxavier savioxavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit late for the review, but looks all good!

@apoorvcodes
Copy link
Member

apoorvcodes commented Feb 13, 2022

@savioxavier lazy, always late for prs

@savioxavier
Copy link
Member

savioxavier commented Feb 13, 2022

@savioxavier lazy, always late for prs

Hey, I got other stuff to do, will try to review future PRs as soon as I can.

@apoorvcodes
Copy link
Member

apoorvcodes commented Feb 13, 2022

@savioxavier lazy, always late for prs

Hey, I got other stuff to do, will try to review future PRs as soon as I can.

It's a joke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savioxavier savioxavier savioxavier approved these changes

@apoorvcodes apoorvcodes apoorvcodes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@megatank58 @savioxavier @apoorvcodes