feat: new docs theme and daisyui#5
Conversation
|
✔️ Deploy Preview for gominima ready! 🔨 Explore the source changes: 5e5ceb7 🔍 Inspect the deploy log: https://app.netlify.com/sites/gominima/deploys/6208cc27480a0d0007f05950 😎 Browse the preview: https://deploy-preview-5--gominima.netlify.app/ |
savioxavier
left a comment
There was a problem hiding this comment.
Looks good to me, might tweak some stuff a bit in later commits.
|
We will most probably unless urgent not be doing any commits to website regarding the core style and core design of the website so if you have any suggestions please drop em here |
Since Minima's core color scheme is blue (derived from its logo), we might have to change the green to blue, just to be consistent. We can keep it green, however, but that would require a complete overhaul of Minima's branding. The font, maybe? It's currently the default font and it doesn't look too good on an Android device. Improper heading styles? The texts look a bit bold to me. Also, the padding might need a fix, a little bit of breathing space, more like. Also, there are a few responsiveness issues with different viewport (I tested it out on Responsively App) so that should be taken care of.
Other than those, it looks pretty good to me! |
apoorvcodes
left a comment
There was a problem hiding this comment.
Change the code block themes to dracula?
|
@megatank58 eta for the pull |
when it's ready |
|
Summary of what's left to be done:
|
|
@savioxavier @apoorvcodes review Conflicts will not be merged, the branch will be force pushed at once to main |
|
Force pushed to main! 🎉 |
savioxavier
left a comment
There was a problem hiding this comment.
Bit late for the review, but looks all good!
|
@savioxavier lazy, always late for prs |
Hey, I got other stuff to do, will try to review future PRs as soon as I can. |
It's a joke |
This pull request is not meant for review or merge yet.
Conflicts will not be resolved and this branch will be force pushing to main, any other PRs are halt till this is merged