fix: correct leaked spec IDs, stale recipe/workflow counts, and dead doc links - #1083
Merged
norrietaylor merged 4 commits intoJul 31, 2026
Merged
Conversation
Redact the internal deployment-model IDs DM1/DM2/DM3 from the user-facing linux-host-setup reference, describing the deployments functionally instead. This follows #1017, which cleaned the same class from `min --help` but stopped before the docs. Refresh two stale counts in AGENTS.md: 40 justfile recipes on Linux (was 33; `just --summary`) and 12 CI workflows (was 11 — the docs-hotfix workflow was missing from the table). Drop the two docs.minimal.dev/concepts links (stacks, sessions) that 404, keeping the surrounding prose as plain text; sibling concept pages resolve but no slug is published for these two. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
📝 WalkthroughWalkthroughRepository guidance counts and workflow documentation were corrected. Reference documentation was reworded to remove internal deployment identifiers and broken concept links without changing configuration semantics. ChangesDocumentation accuracy
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
norrietaylor
approved these changes
Jul 29, 2026
norrietaylor
marked this pull request as ready for review
July 29, 2026 20:54
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/reference/minimal-dot-toml.md`:
- Around line 126-127: Update the session introduction in the minimal TOML
reference so it is a complete sentence with “[session]” as the subject, while
preserving the existing meaning and continuation about shared primitives.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6e5a4a76-1c45-42c0-b9f2-719b5f273b56
📒 Files selected for processing (3)
AGENTS.mddocs/reference/linux-host-setup.mddocs/reference/minimal-dot-toml.md
Comment on lines
126
to
127
| Contributes to sessions activated | ||
| on this project (`min session activate`). It carries the same primitives as a |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Make the session introduction a complete sentence.
Contributes to sessions activated... has no subject after the link removal. Use “The [session] section contributes to sessions activated…” to preserve the meaning while keeping the documentation grammatically clear.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/reference/minimal-dot-toml.md` around lines 126 - 127, Update the
session introduction in the minimal TOML reference so it is a complete sentence
with “[session]” as the subject, while preserving the existing meaning and
continuation about shared primitives.
This was referenced Jul 29, 2026
norrietaylor
approved these changes
Jul 31, 2026
norrietaylor
enabled auto-merge (squash)
July 31, 2026 05:12
norrietaylor
deleted the
inbox-patch/docs-accuracy-fixes-c2341863e3d83bd8
branch
July 31, 2026 05:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Protected files were modified in this change.
This pull request is in
request_reviewmode and requires explicit human scrutiny before merge.Protected files:
AGENTS.mdFixes #1072
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABKsvK7w
Four documentation accuracy defects, each a localized edit:
docs/reference/linux-host-setup.md: replaced the internal deployment-model IDs DM1/DM2/DM3 with functional descriptions — the same class fix: Redact internal spec identifiers (DM1, R4.4) from min --help output #1017 cleaned frommin --helpbut left in the docs (DM1–DM5 are internal networking-spec IDs, informed by G-N7: minvmd supervises exactly one VM; spec says DM1/DM3 support one or more #633).AGENTS.md: the recipe count was stale —just --summaryyields 40 recipes on Linux, not 33. The reporter compared macOS's 35 to the stale 33; once corrected the "macOS shows a smaller set" clause holds (35 < 40), so only the number changed.AGENTS.md: bumped the workflow count 11 → 12 and added the missingdocs-hotfixtable row.docs/reference/minimal-dot-toml.md: removed the twodocs.minimal.dev/concepts/{stacks,sessions}links that 404 (sibling concept pages resolve, but no slug is published for these two), keeping the surrounding prose.Verification
cargo fmt --all --check — clean, no drift
cargo clippy --workspace --locked -- -D warnings — Finished, 0 warnings
cargo build --workspace --locked — Finished dev profile in 4m 26s
cargo test --workspace --locked — all unit suites + doctests ok, 0 failed
Note
Update AGENTS.md to correct workflow count and document the docs hotfix workflow
Updates AGENTS.md to reflect 12 workflows on main (up from 11) and adds a table entry describing the manual docs hotfix process, which repoints public docs in the gominimal/webapp to a selected main SHA without cutting a binary release.
Macroscope summarized 81f7df3.
Summary by CodeRabbit
minimalddeployment environments are affected by AppArmor and user namespace restrictions.