Skip to content

[worker:doc-drift] document [stack] as canonical minimal.toml build section - #743

Merged
norrietaylor merged 1 commit into
mainfrom
chore/doc-drift-stack-section-ae9b567c1e1c1cc4
Jul 14, 2026
Merged

[worker:doc-drift] document [stack] as canonical minimal.toml build section#743
norrietaylor merged 1 commit into
mainfrom
chore/doc-drift-stack-section-ae9b567c1e1c1cc4

Conversation

@gominimal-aw-bot

@gominimal-aw-bot gominimal-aw-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Issue

docs/reference/minimal-dot-toml.md documented the build-configuration section
exclusively as [harness], but the implementation renamed the canonical
minimal.toml key to [stack]. In crates/mfile/src/lib.rs:617-621 the serde
field is stack, and harness is only a backward-compatibility alias
explicitly scheduled for removal after July 2026:

/// The stack configured on this repository, if any.
///
/// TODO: Remove `harness` alias after July 2026.
#[serde(default, alias = "harness")]
pub stack: Option<Stack>,

The doc never mentioned [stack], so a reader following the reference would key
their config on a soon-to-be-removed alias and never discover the canonical
name.

Fix

Documentation-only change to docs/reference/minimal-dot-toml.md:

  • Renamed the schema-section heading, its code block, and the example block from
    [harness] to [stack].
  • Updated the frontmatter description to list stack instead of harness.
  • Added a one-line note that [harness] is accepted as a deprecated alias for
    [stack], pending removal after July 2026, so existing configs still resolve.
  • Kept the {#harness} heading anchor so existing inbound #harness deep links
    continue to resolve.

Scope is limited to the [harness] -> [stack] rename identified in the issue;
no adjacent docs were refactored.

Verification

This is a documentation-only diff — no .rs, Cargo.toml, or Cargo.lock
files were touched — so no Rust source-compile self-check applies (a markdown
edit does not compile, and the change cannot affect any build/lint/test gate).
The non-bypassable host backstop still gates cargo fmt --all --check, cargo build --workspace --all-targets --locked, cargo clippy --workspace --all-targets --locked -- -D warnings, and cargo test --workspace --all-targets --locked before this PR opens.

Closes #724

Generated by Chore-issue worker agent (side-repo-ops operator) ·

Summary by CodeRabbit

  • Documentation
    • Updated configuration documentation to use [stack] instead of [harness].
    • Documented [harness] as a deprecated alias accepted until after July 2026.
    • Added guidance to use [stack] in new configuration files.

The minimal.toml schema reference documented the build section only as
`[harness]`, but mfile renamed the canonical serde field to `stack`;
`harness` is now only a deprecated alias scheduled for removal after
July 2026. Rename the section, example, and frontmatter to `[stack]`,
keep the `#harness` anchor to preserve inbound links, and note the
deprecated alias.

Closes #724
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The minimal.toml reference now documents [stack] as the canonical build-configuration section, updates its examples and schema description, and notes [harness] as a deprecated alias scheduled for removal after July 2026.

Changes

Configuration reference

Layer / File(s) Summary
Document canonical stack schema
docs/reference/minimal-dot-toml.md
Updates the schema overview and example to use [stack], and documents [harness] as a deprecated alias with its removal timeline.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • gominimal/pkgs#250: Renames harness-related containers and entrypoints to stack terminology.
  • gominimal/minimal#424: Coordinates harness-to-stack directory and configuration-key deprecation changes.

Poem

A bunny hops through TOML bright,
[stack] now leads the way,
While [harness] rests by moonlight,
An alias for today.
Configs bloom, clean and clear—
“Hop forward!” says the hare.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The doc updates [stack] as canonical in the frontmatter, example, and schema, and notes [harness] as a deprecated alias.
Out of Scope Changes check ✅ Passed The changes stay within docs/reference/minimal-dot-toml.md and match the requested [harness] to [stack] documentation update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the documentation update making [stack] the canonical minimal.toml build section.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@norrietaylor
norrietaylor merged commit 2f872ed into main Jul 14, 2026
28 checks passed
@norrietaylor
norrietaylor deleted the chore/doc-drift-stack-section-ae9b567c1e1c1cc4 branch July 14, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

agent:doc-drift: minimal.toml schema doc still documents [harness] as the primary section, but code renamed it to [stack]

2 participants