chore(stacks)!: rename harnesses to stacks by twitchyliquid64 · Pull Request #250 · gominimal/pkgs

twitchyliquid64 · 2026-06-15T22:39:51Z

Requires minimal 0.4.1, released almost a month ago

Summary by CodeRabbit

Chores
- Updated minimum toolchain and stdlib version requirement to 0.0.15.
- Refactored stack configuration structure across all build tool integrations for improved consistency and maintainability.

coderabbitai · 2026-06-15T22:40:04Z

📝 Walkthrough

Walkthrough

minimal.toml bumps the stdlib minimum_version from 0.0.11 to 0.0.15. All 19 stacks/*/stack.ncl files uniformly rename the import destructuring binding and top-level configuration block from harness to stack, with no changes to any stack's internal configuration.

Changes

harness → stack rename

Layer / File(s)	Summary
stdlib minimum version bump `minimal.toml`	Updates `minimum_version` in the `[stdlib]` section from `0.0.11` to `0.0.15`.
harness → stack rename in all stack definitions `stacks/bun/stack.ncl`, `stacks/cabal/stack.ncl`, `stacks/cmake/stack.ncl`, `stacks/deno/stack.ncl`, `stacks/go/stack.ncl`, `stacks/gradle/stack.ncl`, `stacks/make/stack.ncl`, `stacks/maven/stack.ncl`, `stacks/meson/stack.ncl`, `stacks/npm/stack.ncl`, `stacks/pip/stack.ncl`, `stacks/pnpm/stack.ncl`, `stacks/pulumi-go/stack.ncl`, `stacks/pulumi-nodejs/stack.ncl`, `stacks/rust/stack.ncl`, `stacks/shell/stack.ncl`, `stacks/stack/stack.ncl`, `stacks/uv/stack.ncl`, `stacks/zig/stack.ncl`	Each file changes `let { harness, .. } = import "minimal.ncl" in harness { ... }` to `let { stack, .. } = import "minimal.ncl" in stack { ... }`. All internal stack configurations are unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 A harness was worn, now a stack takes its place,
Nineteen files updated with minimal.ncl's grace.
The version hops forward from eleven to fifteen,
The tidiest rename this rabbit has seen!
hop hop ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely describes the main change: renaming harnesses to stacks across the codebase. It is specific, focused, and directly reflects the primary purpose of the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch tom/stacks

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@minimal.toml`:
- Line 2: The minimum_version value is set to "0.0.15" but the breaking changes
in this PR require at least version "0.4.1" to function correctly. Update the
minimum_version field to "0.4.1" to ensure that only compatible stdlib versions
are allowed to use this code and prevent runtime failures from unsupported
consumers running older versions.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c2f3aadf-8670-42a7-b9e1-1a13b0b4a4c3

📥 Commits

Reviewing files that changed from the base of the PR and between 6e6f29b and aa55a66.

📒 Files selected for processing (20)

minimal.toml
stacks/bun/stack.ncl
stacks/cabal/stack.ncl
stacks/cmake/stack.ncl
stacks/deno/stack.ncl
stacks/go/stack.ncl
stacks/gradle/stack.ncl
stacks/make/stack.ncl
stacks/maven/stack.ncl
stacks/meson/stack.ncl
stacks/npm/stack.ncl
stacks/pip/stack.ncl
stacks/pnpm/stack.ncl
stacks/pulumi-go/stack.ncl
stacks/pulumi-nodejs/stack.ncl
stacks/rust/stack.ncl
stacks/shell/stack.ncl
stacks/stack/stack.ncl
stacks/uv/stack.ncl
stacks/zig/stack.ncl

coderabbitai · 2026-06-15T22:43:52Z

@@ -1,5 +1,5 @@
 [stdlib]
-minimum_version = "0.0.11"
+minimum_version = "0.0.15"


⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Minimum stdlib version does not match the stated breaking-change requirement.

Line 2 pins minimum_version to 0.0.15, but this PR’s objective says the breaking rename requires 0.4.1+. Keeping 0.0.15 weakens the compatibility gate and may permit unsupported consumers.

Suggested fix

[stdlib] -minimum_version = "0.0.15" +minimum_version = "0.4.1"

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

minimum_version = "0.0.15"

[stdlib]

minimum_version = "0.4.1"

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@minimal.toml` at line 2, The minimum_version value is set to "0.0.15" but the breaking changes in this PR require at least version "0.4.1" to function correctly. Update the minimum_version field to "0.4.1" to ensure that only compatible stdlib versions are allowed to use this code and prevent runtime failures from unsupported consumers running older versions.

bryan-minimal

LGTM RIP harness

chore(stacks)\!: rename harnesses to stacks

aa55a66

twitchyliquid64 requested a review from bryan-minimal June 15, 2026 22:39

coderabbitai Bot reviewed Jun 15, 2026

View reviewed changes

twitchyliquid64 changed the title ~~chore(stacks)\!: rename harnesses to stacks~~ chore(stacks)!: rename harnesses to stacks Jun 15, 2026

bryan-minimal approved these changes Jun 15, 2026

View reviewed changes

twitchyliquid64 mentioned this pull request Jun 15, 2026

chore!: rip old support for old harnesses/ dir gominimal/minimal#424

Merged

twitchyliquid64 enabled auto-merge June 15, 2026 22:55

twitchyliquid64 added this pull request to the merge queue Jun 16, 2026

Merged via the queue into main with commit 560b0d0 Jun 16, 2026
4 checks passed

twitchyliquid64 deleted the tom/stacks branch June 16, 2026 04:32

coderabbitai Bot mentioned this pull request Jun 29, 2026

refactor(op): move init and update code into op crate gominimal/minimal#592

Merged

coderabbitai Bot mentioned this pull request Jul 14, 2026

[worker:doc-drift] document [stack] as canonical minimal.toml build section gominimal/minimal#743

Merged

Navigation Menu

Uh oh!

chore(stacks)!: rename harnesses to stacks - #250

chore(stacks)!: rename harnesses to stacks#250
twitchyliquid64 merged 1 commit into
mainfrom
tom/stacks

twitchyliquid64 commented Jun 15, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 15, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Jun 15, 2026

Uh oh!

bryan-minimal left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

twitchyliquid64 commented Jun 15, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

bryan-minimal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

twitchyliquid64 commented Jun 15, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 15, 2026 •

edited

Loading