Skip to content

chore: update a few deps - #357

Merged
twitchyliquid64 merged 1 commit into
mainfrom
tom/update
Jun 5, 2026
Merged

chore: update a few deps#357
twitchyliquid64 merged 1 commit into
mainfrom
tom/update

Conversation

@twitchyliquid64

@twitchyliquid64 twitchyliquid64 commented Jun 5, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated Google Cloud libraries to latest compatible versions for improved stability.
    • Upgraded language core library to the latest stable release version.

@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates workspace dependencies in Cargo.toml: Google Cloud crates (google-cloud-gax and google-cloud-storage) are bumped to newer patch/minor versions, and nickel-lang-core is migrated from a pinned Git dependency to the published crates.io 0.18 release while preserving feature flags.

Changes

Workspace Dependency Updates

Layer / File(s) Summary
Workspace dependency version updates
Cargo.toml
Google Cloud crates are bumped (google-cloud-gax 1.12 → 1.13, google-cloud-storage 1.6 → 1.7). nickel-lang-core is switched from a pinned Git revision to crates.io release 0.18 with default-features = false and format feature enabled.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • gominimal/minimal#278: Prior PR updating the same workspace dependencies with similar Google Cloud version bumps and nickel-lang-core source migration at the manifest level.

Suggested reviewers

  • 0chroma
  • evanspearman
  • jtnkminimal
  • norrietaylor

Poem

🐰 A bunny hops through deps so clear,
Google Clouds now bright and near,
Nickel-lang from git takes flight,
To crates.io's release so right—
Version bumps done pure and keen! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating workspace dependencies (google-cloud-gax, google-cloud-storage, nickel-lang-core).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Cargo.toml (1)

55-68: Consider running cargo audit for comprehensive vulnerability scanning.

While the verification scripts check GitHub advisories, cargo audit provides a complementary scan against the RustSec advisory database for all dependencies in the resolved dependency tree.

cargo audit

Based on learnings from gominimal/minimalert: Run cargo audit to check for vulnerabilities before commit.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Cargo.toml` around lines 55 - 68, Add a RustSec audit step by running "cargo
audit" against the resolved dependency tree (install the cargo-audit tool if
needed), fix or update any vulnerable crates discovered (e.g., review pinned git
dependency hakoniwa and other entries in Cargo.toml such as google-cloud-* and
nickel-lang-core), and add this check to CI or your verification scripts so
future PRs run cargo audit automatically.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@Cargo.toml`:
- Around line 55-68: Add a RustSec audit step by running "cargo audit" against
the resolved dependency tree (install the cargo-audit tool if needed), fix or
update any vulnerable crates discovered (e.g., review pinned git dependency
hakoniwa and other entries in Cargo.toml such as google-cloud-* and
nickel-lang-core), and add this check to CI or your verification scripts so
future PRs run cargo audit automatically.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9ead5c94-fade-47ef-8404-234ec8b21530

📥 Commits

Reviewing files that changed from the base of the PR and between 0f21eee and edeae0e.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml

@bryan-minimal bryan-minimal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twitchyliquid64
twitchyliquid64 merged commit 35fe939 into main Jun 5, 2026
41 checks passed
@twitchyliquid64
twitchyliquid64 deleted the tom/update branch June 5, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants