Skip to content

chore(deps): update nickel-lang-core crate to coalesce versions - #447

Merged
twitchyliquid64 merged 1 commit into
mainfrom
tom/update
Jun 17, 2026
Merged

chore(deps): update nickel-lang-core crate to coalesce versions#447
twitchyliquid64 merged 1 commit into
mainfrom
tom/update

Conversation

@twitchyliquid64

@twitchyliquid64 twitchyliquid64 commented Jun 17, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Now that nickel-lang/nickel#2619 is merged, we can depend on it and reduce the total number of deps we use. Also managed to prune a duplicate-version tree by turning off a feature in our terminal parser we dont use.

Summary by CodeRabbit

Chores

  • Updated workspace dependencies and their related configuration settings for proper alignment with current development standards and requirements. Appropriately adjusted feature compilation flags and modified dependency source selections for the overall project infrastructure. These changes ensure proper build compatibility and ongoing testing support without affecting any user-facing features or application behavior.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4592c7f1-3595-438e-b763-abda0d6fd06f

📥 Commits

Reviewing files that changed from the base of the PR and between 64eeeb1 and 3de7f33.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml
📝 Walkthrough

Walkthrough

Two workspace dependency entries in Cargo.toml are modified: nickel-lang-core is switched from the crates.io 0.18 release to a git dependency pinned to a specific revision (e8a0ab9), and vt100-ctt is updated to explicitly disable default features while retaining its version constraint.

Changes

Workspace Dependency Updates

Layer / File(s) Summary
nickel-lang-core git pin and vt100-ctt feature flag
Cargo.toml		 nickel-lang-core is switched from version = "0.18" to a git-pinned revision with default-features = false and features = ["format"], with a comment to revert once a new crates.io version is released. vt100-ctt is converted from a bare version string to an inline table that adds default-features = false.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • gominimal/minimal#278: Modifies the same nickel-lang-core workspace git dependency in Cargo.toml, bumping the pinned git revision.
  • gominimal/minimal#357: Directly inverses this change — switches nickel-lang-core between the git-pinned revision and the crates.io 0.18 release with the same feature flags.

Suggested reviewers

  • norrietaylor
  • 0chroma
  • evanspearman
  • jtnkminimal

Poem

🐇 A crate once fetched from crates.io's shelf,
Now points to a git rev all by itself.
A comment reminds us: "revert this soon!"
And vt100 trims its defaults by noon.
Hop hop, the lockfile shall follow suit! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title refers to updating nickel-lang-core and coalescing versions, which directly aligns with the primary objective of reducing dependencies and removing duplicate versions from the dependency tree.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@twitchyliquid64
twitchyliquid64 enabled auto-merge (squash) June 17, 2026 21:41
@twitchyliquid64
twitchyliquid64 merged commit 0988e65 into main Jun 17, 2026
33 checks passed
@twitchyliquid64
twitchyliquid64 deleted the tom/update branch June 17, 2026 21:53
@norrietaylor norrietaylor mentioned this pull request Jul 31, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evanspearman evanspearman evanspearman approved these changes
@0chroma 0chroma Awaiting requested review from 0chroma
@msample msample Awaiting requested review from msample
@norrietaylor norrietaylor Awaiting requested review from norrietaylor
@bryan-minimal bryan-minimal Awaiting requested review from bryan-minimal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twitchyliquid64 @evanspearman