fix(release CI): fix 'chmod: cannot access 'artifacts/*-macos-*': No such file or directory' - #608
Conversation
…such file or directory'
📝 WalkthroughWalkthroughThe release job's CI workflow was updated to broaden the artifact download and chmod glob patterns from platform-specific patterns to a generic pattern matching all artifact names. ChangesCI Release Artifact Glob Update
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/ci.yml (1)
249-267: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick winFlatten the downloaded artifacts before using them.
actions/download-artifact@v8is still using the defaultmerge-multiple: false, sopattern: "*-*-*"downloads each artifact into its own subdirectory. That makeschmod +x artifacts/*-*-*target directories, and the completion/release steps still look for binaries at the wrong paths.Add
merge-multiple: truehere, or update the later paths toartifacts/<artifact-name>/<binary>.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/ci.yml around lines 249 - 267, Downloaded artifacts are being kept in per-artifact subdirectories, so the chmod and completion generation steps in the workflow use the wrong paths. Update the Download artifacts step in the ci workflow by enabling merge-multiple in actions/download-artifact@v8, or adjust the later chmod +x and artifacts/<name> binary references in the Generate completions step to point to the nested artifact directories.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/ci.yml:
- Around line 249-267: Downloaded artifacts are being kept in per-artifact
subdirectories, so the chmod and completion generation steps in the workflow use
the wrong paths. Update the Download artifacts step in the ci workflow by
enabling merge-multiple in actions/download-artifact@v8, or adjust the later
chmod +x and artifacts/<name> binary references in the Generate completions step
to point to the nested artifact directories.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 56193c52-fa87-4053-827d-3a86d1019f16
📒 Files selected for processing (1)
.github/workflows/ci.yml
Summary by CodeRabbit