You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7634790f-c40a-4a04-a9a8-47ffe58e5241
📥 Commits
Reviewing files that changed from the base of the PR and between 504d664 and fbf4f98.
📒 Files selected for processing (1)
.github/workflows/ci.yml
📝 Walkthrough
Walkthrough
The build-release-macos-arm64 CI job is updated to build a minimal binary in addition to minvmd, rename both with a -macos-arm64 suffix, and upload both artifacts. The prior minvmd-only rename/upload sequence, including a codesign step, is removed.
Changes
CI macOS arm64 Release Build
Layer / File(s)
Summary
Build, rename, and upload minimal binary alongside minvmd .github/workflows/ci.yml
Adds a cargo build step for minimal, expands the artifact rename step to move both minvmd and minimal with the platform suffix, and adds an upload step for minimal, removing the prior minvmd-only block that included a codesign step.
gominimal/minimal#608: Both PRs update artifact handling in .github/workflows/ci.yml for macOS release artifacts, including the new minimal naming.
gominimal/minimal#609: Both PRs update release artifact renaming/uploading logic in .github/workflows/ci.yml.
gominimal/minimal#614: Both PRs modify the same build-release-macos-arm64 job's binary build and upload logic.
Suggested reviewers:norrietaylor, bryan-minimal
Poem
A rabbit hops through YAML fields so neat,
Building minimal alongside its minvmd feat,
Renamed and packed with an arm64 tag,
Uploaded snug in the CI bag,
Hop hop hooray, ship complete! 🐇📦
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also drop the codesign as its worthless - only works on that runner machine.
Summary by CodeRabbit