Skip to content

feat(ci): use gominimal/run-task GHA to dogfood - #675

Merged
twitchyliquid64 merged 1 commit into
mainfrom
tom/release
Jul 8, 2026
Merged

feat(ci): use gominimal/run-task GHA to dogfood#675
twitchyliquid64 merged 1 commit into
mainfrom
tom/release

Conversation

@twitchyliquid64

@twitchyliquid64 twitchyliquid64 commented Jul 8, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated the CI workflow to improve build-smoke execution reliability.
    • Added steps to better manage disk space and reuse cached build state during automated runs.
    • Switched the smoke test process to a newer task-based runner and build channel.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The CI workflow's dogfood job smoke-test steps were replaced. The prior setup-minimal action and minimal run build-smoke invocation are removed, replaced with steps to free disk space, checkout code, cache Cargo state, and run gominimal/run-task for build-smoke on the unstable channel.

Changes

CI Workflow Update

Layer / File(s) Summary
Dogfood smoke-test step replacement
.github/workflows/ci.yml		 Replaces setup-minimal/minimal run build-smoke flow with disk cleanup, checkout, Cargo cache, and gominimal/run-task execution targeting build-smoke on unstable channel.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: norrietaylor, evanspearman, 0chroma

Poem

A rabbit hops through workflows anew,
Freeing disk space, caching Cargo too,
No more old setup, just tasks that fly,
Build-smoke runs on unstable sky. 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main CI change: switching the dogfood job to gominimal/run-task.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@twitchyliquid64
twitchyliquid64 enabled auto-merge (squash) July 8, 2026 21:03
coderabbitai[bot]
coderabbitai Bot reviewed Jul 8, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)

43-49: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Duplicated "Free Disk Space" step across clippy and dogfood jobs.

Both jobs now carry nearly identical endersonmenezes/free-disk-space@v3 blocks. Consider extracting this into a local composite action (similar to ./.github/actions/setup-minimal) to avoid drift between the two copies.

Also applies to: 83-89

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml around lines 43 - 49, The duplicated Free Disk
Space step in the clippy and dogfood jobs should be consolidated so the
configuration lives in one place. Move the shared
endersonmenezes/free-disk-space@v3 setup into a reusable local composite action,
following the same pattern used by setup-minimal, and update both jobs to call
that action instead of keeping separate inline copies. Use the existing Free
Disk Space step and setup-minimal action as the main symbols to locate the
workflow sections.
🤖 Prompt for all review comments with AI agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 43-49: The duplicated Free Disk Space step in the clippy and
dogfood jobs should be consolidated so the configuration lives in one place.
Move the shared endersonmenezes/free-disk-space@v3 setup into a reusable local
composite action, following the same pattern used by setup-minimal, and update
both jobs to call that action instead of keeping separate inline copies. Use the
existing Free Disk Space step and setup-minimal action as the main symbols to
locate the workflow sections.
ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 345b28dd-7313-407c-a765-a754f27a88c4

📥 Commits

Reviewing files that changed from the base of the PR and between a53dd2a and ae12d5f.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

@twitchyliquid64
twitchyliquid64 merged commit 1c35174 into main Jul 8, 2026
9 checks passed
@twitchyliquid64
twitchyliquid64 deleted the tom/release branch July 8, 2026 21:34
@coderabbitai coderabbitai Bot mentioned this pull request Jul 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@norrietaylor norrietaylor norrietaylor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twitchyliquid64 @norrietaylor