Skip to content

feat(ci): use new gominimal/check action - #735

Merged
twitchyliquid64 merged 1 commit into
mainfrom
tom/session-prompt
Jul 13, 2026
Merged

feat(ci): use new gominimal/check action#735
twitchyliquid64 merged 1 commit into
mainfrom
tom/session-prompt

Conversation

@twitchyliquid64

@twitchyliquid64 twitchyliquid64 commented Jul 13, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated continuous integration checks to use the maintained standard checking action.
    • Removed the previous custom setup process for Minimal tooling.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9b0337f9-62ed-490f-8b89-4d3fe1a3fab0

📥 Commits

Reviewing files that changed from the base of the PR and between 638a788 and 55b6431.

📒 Files selected for processing (2)
  • .github/actions/setup-minimal/action.yml
  • .github/workflows/ci.yml
💤 Files with no reviewable changes (1)
  • .github/actions/setup-minimal/action.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

The local setup-minimal composite action was removed, and the minimal-check CI job now uses gominimal/check@v1 on the unstable channel.

Changes

Minimal CI migration

Layer / File(s) Summary
Shared Minimal check action
.github/workflows/ci.yml, .github/actions/setup-minimal/action.yml
The workflow uses gominimal/check@v1, replacing the removed local setup action and direct Minimal command.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: evanspearman, msample, norrietaylor, bryan-minimal

Poem

A bunny watched the checks take flight,
From local setup into shared light.
The unstable channel leads the way,
While old shims quietly decay.
CI hops along, neat and bright.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main CI change: switching to the new gominimal/check action.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@twitchyliquid64
twitchyliquid64 enabled auto-merge (squash) July 13, 2026 21:14
@twitchyliquid64
twitchyliquid64 merged commit 3045b55 into main Jul 13, 2026
28 checks passed
@twitchyliquid64
twitchyliquid64 deleted the tom/session-prompt branch July 13, 2026 21:29
norrietaylor added a commit that referenced this pull request Jul 14, 2026
Resolve the conflicts from the commits that landed on main since this
branch's merge-base (#721, #732, #734, #735, #722), keeping main's
content and re-applying the `min` binary-target rename on top.

- justfile: main folded `up` into `dm1` (#722), so the branch's older
  `up` recipe is dropped rather than resurrected. Main's `dm1` invoked
  the `{{minimal}}` variable this branch renames, which would have left
  `just` unable to resolve it; it now invokes `{{min-bin}}`.
- CI lanes: keep main's rewritten jobs and steps, renaming only the CLI
  build flags and built-binary paths (`--bin min`, `target/debug/min`).

Also point the sessions example project at `./target/debug/min`; the
binary path it documented no longer exists after the rename.

Published release asset names (`minimal-linux-amd64`, ...), the macOS
`minimal` shim, and the `minimal` crate and lib target are deliberately
left alone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants