ci,test: auto-discover integration harnesses by name convention across every lane - #732

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

crates/minimald/src/lib.rs (1)

62-67: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Do not silently discard directory-entry errors.

filter_map(Result::ok) can omit an unreadable *.rs entry, allowing the naming guard to pass without inspecting every test file. Propagate the error or fail with context so this guard remains fail-closed.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/minimald/src/lib.rs` around lines 62 - 67, Update the test-file
discovery flow building offenders so directory-entry errors from
std::fs::read_dir are not discarded by filter_map(Result::ok). Propagate the
error or fail explicitly with context, while preserving the existing filtering
of regular Rust files and the fail-closed naming guard behavior.

crates/minvmd/tests/krun_smoke_integration.rs (1)

69-83: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Reject partially configured full-path environments.

If only one of MINVMD_KERNEL_PATH or MINVMD_ROOTFS_PATH is set, this test enters the bring-up-only branch and can pass without exercising start_enter. Require both variables or neither so CI misconfiguration cannot silently reduce coverage.

Proposed fix

 let kernel_set = std::env::var("MINVMD_KERNEL_PATH").is_ok();
 let rootfs_set = std::env::var("MINVMD_ROOTFS_PATH").is_ok();
+assert_eq!(
+    kernel_set, rootfs_set,
+    "MINVMD_KERNEL_PATH and MINVMD_ROOTFS_PATH must be set together"
+);

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

    let kernel_set = std::env::var("MINVMD_KERNEL_PATH").is_ok();
    let rootfs_set = std::env::var("MINVMD_ROOTFS_PATH").is_ok();
    assert_eq!(
        kernel_set, rootfs_set,
        "MINVMD_KERNEL_PATH and MINVMD_ROOTFS_PATH must be set together"
    );

    if kernel_set && rootfs_set {
        // Full path: helper called start_enter. Accept the libkrun-defined
        // exit code set per the function's own error-code documentation.
        assert!(
            stderr.contains("STAGE: start_enter"),
            "missing start_enter marker (full path)\n--- stderr ---\n{stderr}",
        );
        assert!(
            matches!(code, 0 | 2 | 125 | 126 | 127),
            "unexpected child exit code {code} on full path; expected 0 | 2 | 125 | 126 | 127",
        );
    } else {

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/minvmd/tests/krun_smoke_integration.rs` around lines 69 - 83, Update
the environment-variable branching around kernel_set and rootfs_set to reject
partial configuration: require both MINVMD_KERNEL_PATH and MINVMD_ROOTFS_PATH to
be set or neither to be set, and fail the test explicitly when only one is
present. Preserve the existing full-path start_enter assertions and
bring-up-only behavior for valid configurations.

docs/specs/01-spec-minvmd-host-daemon/01-spec-minvmd-host-daemon.md (1)

250-253: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Remove the retired bridge test from the active proof artifact.

The preceding bullet still presents tests/bridge_e2e.rs as a required passing test, while this paragraph says it was removed. Replace it with minimald_session_integration.rs or explicitly mark the entire entry as historical.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/specs/01-spec-minvmd-host-daemon/01-spec-minvmd-host-daemon.md` around
lines 250 - 253, Update the preceding test-reference bullet in the active proof
artifact to replace tests/bridge_e2e.rs with
tests/minimald_session_integration.rs, keeping the entry presented as a required
passing test rather than referencing the retired bridge test.

docs/specs/02-spec-minvmd-linux-kvm/02-spec-minvmd-linux-kvm.md (1)

218-239: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Remove the obsolete bridge_e2e requirement.

The affected-area list and R3.3 still require tests/bridge_e2e.rs, but the same block says that harness was removed. Delete this requirement and retain minimald_session_integration.rs as the active session proof.

🧰 Tools

🪛 LanguageTool

[uncategorized] ~226-~226: The operating system from Apple is written “macOS”.
Context: ...s/boot_integration.rsshall remove the#![cfg(target_os = "macos")]` file-level attribute. The READY-m...

(MAC_OS)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/specs/02-spec-minvmd-linux-kvm/02-spec-minvmd-linux-kvm.md` around lines
218 - 239, Remove the obsolete bridge_e2e.rs entry from the affected areas and
delete requirement R3.3, while retaining minimald_session_integration.rs as the
active Linux session integration proof. Leave R3.1 and R3.2 unchanged.