Skip to content

fix(nightly): remove broken verify-ci gate - #807

Closed
twitchyliquid64 wants to merge 1 commit into
mainfrom
tom/session-inner
Closed

fix(nightly): remove broken verify-ci gate#807
twitchyliquid64 wants to merge 1 commit into
mainfrom
tom/session-inner

Conversation

@twitchyliquid64

@twitchyliquid64 twitchyliquid64 commented Jul 17, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

verify-ci only worked when the HEAD commit had resulted in all those tests having being launched (they are conditional), otherwise it would fail. Also it broke the release job being called from nightly.

Summary by CodeRabbit

  • Release Process
    • Removed the required CI verification gate from the release workflow.
    • Removed the option to bypass required CI checks.
    • Releases now depend only on the remaining configured release steps.
    • Retained support for dry-run releases.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: edb6908a-8dab-42b7-9fa6-cc5bcf027b6f

📥 Commits

Reviewing files that changed from the base of the PR and between 9306b5c and 2e6cf89.

📒 Files selected for processing (1)
  • .github/workflows/release.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/release.yml
📝 Walkthrough

Walkthrough

The release workflow retains only the dry_run callable input, removes the verify-ci job, and no longer makes the release job depend on that verification step.

Changes

Release workflow orchestration

Layer / File(s) Summary
Remove release CI verification gate
.github/workflows/release.yml		 The workflow removes the skip_ci_verify input and verify-ci job, and updates release.needs so releases are no longer blocked by CI verification.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: norrietaylor

Poem

I’m a bunny with a release to run,
The CI gate is now undone.
dry_run stays within the flow,
While verify-ci hops below.
No extra wait—off we go!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: removing the broken verify-ci gate from the nightly release workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@twitchyliquid64
twitchyliquid64 enabled auto-merge (squash) July 17, 2026 16:45
auto-merge was automatically disabled July 17, 2026 16:47

Pull request was closed

@coderabbitai coderabbitai Bot mentioned this pull request Jul 17, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@norrietaylor norrietaylor Awaiting requested review from norrietaylor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@twitchyliquid64