ci(nightly): add dry_run and skip_ci_verify dispatch inputs - #809
Conversation
Mirror release.yml's workflow_dispatch inputs on nightly.yml and pass them through the workflow_call. dry_run forces the build even when HEAD is already staged (a rehearsal that skips itself proves nothing), runs the smokes against the fresh artifacts, and never advances the nightly channel — release.yml stages nothing on a dry run, and re-pointing nightly at a previously staged HEAD would make the rehearsal publish. skip_ci_verify passes straight through to release.yml's verify-ci gate. Scheduled runs see an empty inputs context and keep today's behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe nightly workflow adds manual ChangesNightly workflow controls
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/nightly.yml:
- Around line 14-22: Revert the changes to the nightly workflow, including the
added dispatch inputs, reusable release-workflow forwarding, and nightly
promotion gating. Do not modify files under .github/workflows; route any
required CI-layer change through the CODEOWNER-approved workflow instead.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: dc9cf99d-7be0-47b5-8329-67ed81e8cc3a
📒 Files selected for processing (1)
.github/workflows/nightly.yml
What
Mirrors release.yml's
workflow_dispatchinputs on nightly.yml and passes them through theworkflow_call:dry_run— build, sign, assemble, and smoke everything, publish nothing. Two nightly-specific behaviors:should_release == 'true' || inputs.dry_run == true) — a rehearsal that skips itself proves nothing. The smoke jobs then run against the fresh artifacts.promote-nightlygains&& !inputs.dry_run. A dry-run release stages nothing, and re-pointingnightlyat a previously staged HEAD would make the rehearsal publish.skip_ci_verify— straight pass-through to release.yml's verify-ci gate (admin override for a commit whose checks are known-good but unreported).Scheduled runs see an empty
inputscontext, so every expression falls back to today's behavior.This makes
gh workflow run nightly.yml -f dry_run=truethe safe end-to-end rehearsal of the whole nightly pipeline — including the smoke jobs added in #759 — which #759's description noted wasn't previously possible.Authorization (workflow freeze)
Editing
.github/workflows/is normally frozen and CODEOWNER-gated (seeCLAUDE.md). Owner-directed follow-up to #759, opened for code-owner review.Validation
actionlint(1.7.12) runs clean. Scheduled-path behavior is unchanged by construction (emptyinputscontext); the dispatch path gets its first proof from adry_run=truedispatch once merged.🤖 Generated with Claude Code
Summary by CodeRabbit