Skip to content

ci(nightly): add dry_run and skip_ci_verify dispatch inputs - #809

Merged
norrietaylor merged 1 commit into
mainfrom
ci/nightly-dispatch-inputs
Jul 17, 2026
Merged

ci(nightly): add dry_run and skip_ci_verify dispatch inputs#809
norrietaylor merged 1 commit into
mainfrom
ci/nightly-dispatch-inputs

Conversation

@norrietaylor

@norrietaylor norrietaylor commented Jul 17, 2026

Copy link
Copy Markdown
Member

What

Mirrors release.yml's workflow_dispatch inputs on nightly.yml and passes them through the workflow_call:

  • dry_run — build, sign, assemble, and smoke everything, publish nothing. Two nightly-specific behaviors:
    • Forces the build even when HEAD is already staged (should_release == 'true' || inputs.dry_run == true) — a rehearsal that skips itself proves nothing. The smoke jobs then run against the fresh artifacts.
    • Never advances the channelpromote-nightly gains && !inputs.dry_run. A dry-run release stages nothing, and re-pointing nightly at a previously staged HEAD would make the rehearsal publish.
  • skip_ci_verify — straight pass-through to release.yml's verify-ci gate (admin override for a commit whose checks are known-good but unreported).

Scheduled runs see an empty inputs context, so every expression falls back to today's behavior.

This makes gh workflow run nightly.yml -f dry_run=true the safe end-to-end rehearsal of the whole nightly pipeline — including the smoke jobs added in #759 — which #759's description noted wasn't previously possible.

Authorization (workflow freeze)

Editing .github/workflows/ is normally frozen and CODEOWNER-gated (see CLAUDE.md). Owner-directed follow-up to #759, opened for code-owner review.

Validation

actionlint (1.7.12) runs clean. Scheduled-path behavior is unchanged by construction (empty inputs context); the dispatch path gets its first proof from a dry_run=true dispatch once merged.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added manual nightly workflow options for dry runs and skipping CI verification.
    • Dry runs can now execute release preparation without advancing the release channel.
    • Workflow inputs are forwarded automatically, with safe defaults when omitted.

Mirror release.yml's workflow_dispatch inputs on nightly.yml and pass
them through the workflow_call. dry_run forces the build even when HEAD
is already staged (a rehearsal that skips itself proves nothing), runs
the smokes against the fresh artifacts, and never advances the nightly
channel — release.yml stages nothing on a dry run, and re-pointing
nightly at a previously staged HEAD would make the rehearsal publish.
skip_ci_verify passes straight through to release.yml's verify-ci gate.
Scheduled runs see an empty inputs context and keep today's behavior.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The nightly workflow adds manual dry_run and skip_ci_verify inputs, forwards them to the reusable release workflow, permits release execution during dry runs, and prevents dry-run executions from promoting the nightly channel.

Changes

Nightly workflow controls

Layer / File(s) Summary
Dispatch inputs, release forwarding, and promotion gating
.github/workflows/nightly.yml
Manual dispatches accept dry_run and skip_ci_verify, pass both values to release.yml, and prevent nightly promotion when dry_run is enabled.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • gominimal/minimal#807: Changes the connected skip_ci_verify release-workflow interface and CI verification gate.

Suggested reviewers: twitchyliquid64

Poem

I’m a rabbit with a dry-run flag,
No nightly channel down the track.
CI may skip its checking queue,
Release inputs hop right through.
Safe paws guide the workflow bright!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding nightly dispatch inputs for dry runs and CI verification skipping.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/nightly.yml:
- Around line 14-22: Revert the changes to the nightly workflow, including the
added dispatch inputs, reusable release-workflow forwarding, and nightly
promotion gating. Do not modify files under .github/workflows; route any
required CI-layer change through the CODEOWNER-approved workflow instead.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dc9cf99d-7be0-47b5-8329-67ed81e8cc3a

📥 Commits

Reviewing files that changed from the base of the PR and between 1c2cdea and 6d06712.

📒 Files selected for processing (1)
  • .github/workflows/nightly.yml

Comment thread .github/workflows/nightly.yml
@norrietaylor
norrietaylor enabled auto-merge (squash) July 17, 2026 17:17
@norrietaylor
norrietaylor merged commit 11daebe into main Jul 17, 2026
28 checks passed
@norrietaylor
norrietaylor deleted the ci/nightly-dispatch-inputs branch July 17, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants