docs: reconcile harness build command schema - #813
Merged
jtnkminimal merged 1 commit intoJul 17, 2026
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe harness reference updates the pnpm example to use ChangesHarness specification alignment
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
mitodrummer
approved these changes
Jul 17, 2026
jtnkminimal
deleted the
amp-codex-5.5-test-366-harness-build-command-docs
branch
July 17, 2026 20:52
norrietaylor
added a commit
that referenced
this pull request
Jul 18, 2026
…eatures Audit of docs/reference/ against the code: - cli.md: Linux installs ship min/mip/minimald only; minvmd is a source build (prebuilt amd64 attached to GitHub Releases, no arm64) — per scripts/stage-release.sh COMPONENTS and release-pipeline.md. - minimal-dot-toml.md: rename stale `minimal update`/`minimal materialize` to the mip CLI, and cross-reference that `mip update` rewrites the upstream and sideload locked_commit fields in place (crates/op/src/project/update.rs). - tasks.md: mip run in the args example; document `description` (shown by mip status), the /bin/<cmd> exec resolution, arg defaults making arguments optional, and the full arg datatype forms (arrays, enums, table form with help/default) per the args crate. - build-specs.md: replace the line-anchored stdlib blob link with a stable file link; tests run by `mip check`. - harness-specs.md: `mip build` / `mip init` binary names (light re-audit after #813). - sandbox-operations.md: match the in-sandbox helper (crates/mctx/src/min_helper.sh + env.rs): --session flag and no-flag default, stack.* not harness.* targets, check takes --stacks (not --harnesses) and has no --skip-checkers/short flags, add the build/test shorthands and patched-pkg, mark the surface Linux-only, and add a note disambiguating the helper from the min session CLI. - cli-min.md, cli-mip.md: regenerate the snippets touched by the help text fixes (cache clean, login example) from the rebuilt binaries at d9f2016. - crates/minvmd/README.md: replace the stale "persistent data disk is a follow-up" note with the shipped per-VM /dev/vdb ext4 volume (crates/minvmd/src/volume.rs, spec 08) and update the libkrun guidance for the pinned source build (#694), keeping brew as the local-dev fallback. - frontmatter: every reference page now carries title + description. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_cmdsfield withbuild_cmdbuild_cmdandbuild_cmds_cmdas string-or-argv command specificationsstackconstructorVerification
cargo test -p decode stacks --libbuild_cmdsorharnessconstructor references remain in the documentgit diff --checkCloses #366
(amp-codex-5.5-test-366-harness-build-command-docs)
Summary by CodeRabbit
pnpmharness example to use thestackattribute set.build_cmdfield and its mutually exclusivebuild_cmds_cmdalternative.