ci: add version-age report-only check (inbox#21/#20) - #279

.github/scripts/version_age_report.py (1)

262-263: 💤 Low value

Consider wrapping packages-file read for consistency with dump handling.

The dump file read is wrapped in try/except (lines 246-253), but the packages-file read at lines 262-263 is not. While the workflow guarantees the file exists (line 55 creates it unconditionally), defensive handling here would be consistent with the script's "never crash" philosophy.

This is minor since the workflow-level || echo "::warning::..." catches any exception anyway.

🛡️ Optional defensive wrap

-    with open(args.packages_file) as f:
-        changed = [ln.strip() for ln in f if ln.strip()]
+    try:
+        with open(args.packages_file) as f:
+            changed = [ln.strip() for ln in f if ln.strip()]
+    except OSError as e:
+        emit("## version-age report (informational, non-blocking)\n\n"
+             f"> packages-file unavailable ({type(e).__name__}); skipping. Non-blocking.\n")
+        return 0

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/scripts/version_age_report.py around lines 262 - 263, Wrap the
packages-file read operation (where args.packages_file is opened and lines are
stripped) in a try/except block for consistency with the dump file handling
pattern used elsewhere in the script. Apply the same defensive error handling
approach that is already implemented for the dump file read operation to ensure
the script handles potential file read failures gracefully without crashing.

.github/scripts/version_age_report.py (1)

477-478: 💤 Low value

Minor: Duplicate package names silently take last entry.

If the catalog contains multiple entries with the same name, the dict comprehension keeps only the last one. This is likely rare in practice but could cause confusion if it occurs.

Consider logging a warning when duplicates are detected, or document this behavior:

Optional diagnostic for duplicate detection

-    by_name = {p["name"]: p for p in catalog
-               if isinstance(p, dict) and isinstance(p.get("name"), str)}
+    by_name = {}
+    for p in catalog:
+        if isinstance(p, dict) and isinstance(p.get("name"), str):
+            name = p["name"]
+            if name in by_name:
+                print(f"warning: duplicate catalog entry for {name}, using later")
+            by_name[name] = p

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/scripts/version_age_report.py around lines 477 - 478, The dict
comprehension that creates the by_name dictionary silently keeps only the last
entry when multiple catalog items share the same name value. To fix this, modify
the comprehension to detect duplicates by tracking which names have been seen,
and add a warning log statement that alerts when duplicate package names are
found in the catalog so users are aware of the behavior rather than having it
occur silently.